[jira] [Commented] (CURATOR-585) Discovery sample did not check for exceptions

["王杰 (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CURATOR-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248306#comment-17248306 ] 

王杰 commented on CURATOR-585:
----------------------------

I want to try to repair it myself and submit a PR

> Discovery sample did not check for exceptions
> ---------------------------------------------
>
>                 Key: CURATOR-585
>                 URL: https://issues.apache.org/jira/browse/CURATOR-585
>             Project: Apache Curator
>          Issue Type: Bug
>    Affects Versions: 5.1.0
>         Environment: MacBook Pro (15-inch, 2019)
>            Reporter: 王杰
>            Assignee: Jordan Zimmerman
>            Priority: Minor
>             Fix For: awaiting-response
>
>
> I tried to run `DiscoveryExample` to simulate service discovery, when I first entered list to see the list of registrations, I found that the process exited directly, I checked the code and found that the code threw `NoNodeException` but it was ignored.
> I think if there is no service registered, using `list` should tell me that no service is registered instead of just ignoring the exception and closing the connection, so I am asking this question, what do you think?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)