[GitHub] [superset] john-bodley commented on a diff in pull request #24323: chore: changing FLASK_ENV to FLASK_DEBUG

["john-bodley (via GitHub)" <gi...@apache.org>]

john-bodley commented on code in PR #24323:
URL: https://github.com/apache/superset/pull/24323#discussion_r1224556569


##########
superset/config.py:
##########
@@ -244,7 +244,7 @@ def _try_json_readsha(filepath: str, length: int) -> str | None:
 ]
 
 # Whether to run the web server in debug mode or not
-DEBUG = os.environ.get("FLASK_ENV") == "development"
+DEBUG = os.environ.get("FLASK_DEBUG")

Review Comment:
   Should there be logic to convert a truthy environment variable to a Python bool?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org