[GitHub] [iceberg] fqaiser94 commented on a diff in pull request #6513: API,Core: Support Conditional Commits

["fqaiser94 (via GitHub)" <gi...@apache.org>]

fqaiser94 commented on code in PR #6513:
URL: https://github.com/apache/iceberg/pull/6513#discussion_r1123894288


##########
core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java:
##########
@@ -165,4 +165,9 @@ private Expression dataConflictDetectionFilter() {
       return Expressions.alwaysTrue();
     }
   }
+
+  @Override
+  protected SnapshotUpdate<OverwriteFiles> returnThis() {

Review Comment:
   Changed my mind about this. 
   I've changed the`validateCurrentTable` to now return `void` instead of `ThisT`. 
   This makes the code changes much simpler as we no longer need this `self` method nor do we need to do any java-type-system-gymnastics.  
   The only downside is that method chaining is no longer possible after calling `validateCurrentTable` method which I don't consider to be a big deal. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org