You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/01/13 00:06:18 UTC
Review Request 42221: Removed references to wDRF from allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Joris Van Remoortere.
Repository: mesos
Description
-------
Since wDRF is encapsulated in the choice of sorter, it should not be
mentioned in the allocator code.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
Diff: https://reviews.apache.org/r/42221/diff/
Testing
-------
`make check` on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Re: Review Request 42221: Removed references to wDRF from allocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Jan. 13, 2016, 1:52 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1185
> > <https://reviews.apache.org/r/42221/diff/1/?file=1194999#file1194999line1185>
> >
> > s/framwork/frameworks
>
> Alexander Rukletsov wrote:
> Why do you want plural here?
>
> Guangya Liu wrote:
> It is just typo, I think that we can fix it here as it does not deserve to file another jira to fix it, comments?
It may be a grammatical mistake, but definitely not a typo: I put singular here on purpose. Only a single framework can accept a resource at a time.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114126
-----------------------------------------------------------
On Jan. 12, 2016, 11:06 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42221/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 11:06 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since wDRF is encapsulated in the choice of sorter, it should not be
> mentioned in the allocator code.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
>
> Diff: https://reviews.apache.org/r/42221/diff/
>
>
> Testing
> -------
>
> `make check` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 42221: Removed references to wDRF from allocator.
Posted by Guangya Liu <gy...@gmail.com>.
> On 一月 13, 2016, 1:52 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1185
> > <https://reviews.apache.org/r/42221/diff/1/?file=1194999#file1194999line1185>
> >
> > s/framwork/frameworks
>
> Alexander Rukletsov wrote:
> Why do you want plural here?
>
> Guangya Liu wrote:
> It is just typo, I think that we can fix it here as it does not deserve to file another jira to fix it, comments?
>
> Alexander Rukletsov wrote:
> It may be a grammatical mistake, but definitely not a typo: I put singular here on purpose. Only a single framework can accept a resource at a time.
Get your point, then how about update to "one of the frameworks"?
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114126
-----------------------------------------------------------
On 一月 12, 2016, 11:06 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42221/
> -----------------------------------------------------------
>
> (Updated 一月 12, 2016, 11:06 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since wDRF is encapsulated in the choice of sorter, it should not be
> mentioned in the allocator code.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
>
> Diff: https://reviews.apache.org/r/42221/diff/
>
>
> Testing
> -------
>
> `make check` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 42221: Removed references to wDRF from allocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Jan. 13, 2016, 1:52 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1185
> > <https://reviews.apache.org/r/42221/diff/1/?file=1194999#file1194999line1185>
> >
> > s/framwork/frameworks
Why do you want plural here?
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114126
-----------------------------------------------------------
On Jan. 12, 2016, 11:06 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42221/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 11:06 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since wDRF is encapsulated in the choice of sorter, it should not be
> mentioned in the allocator code.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
>
> Diff: https://reviews.apache.org/r/42221/diff/
>
>
> Testing
> -------
>
> `make check` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 42221: Removed references to wDRF from allocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Jan. 13, 2016, 1:52 a.m., Guangya Liu wrote:
> > Since the comments are mainly to developers, the `second stage` is not very clear to developers, but the `WDRF` seems more clear. If want to update, what about "fair share stage"?
The fairness of the "second" stage is determined by sorters as well. For example, one may write a sorter that favors roles starting with "alex-" : ). What allocator knows is that there are two stages: the first where only quota'ed frameworks are processed and the second for all frameworks.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114126
-----------------------------------------------------------
On Jan. 12, 2016, 11:06 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42221/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 11:06 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since wDRF is encapsulated in the choice of sorter, it should not be
> mentioned in the allocator code.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
>
> Diff: https://reviews.apache.org/r/42221/diff/
>
>
> Testing
> -------
>
> `make check` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 42221: Removed references to wDRF from allocator.
Posted by Guangya Liu <gy...@gmail.com>.
> On 一月 13, 2016, 1:52 a.m., Guangya Liu wrote:
> > Since the comments are mainly to developers, the `second stage` is not very clear to developers, but the `WDRF` seems more clear. If want to update, what about "fair share stage"?
>
> Alexander Rukletsov wrote:
> The fairness of the "second" stage is determined by sorters as well. For example, one may write a sorter that favors roles starting with "alex-" : ). What allocator knows is that there are two stages: the first where only quota'ed frameworks are processed and the second for all frameworks.
OK, seems "second" is more generic which can cover all cases. Thanks for the explanation.
> On 一月 13, 2016, 1:52 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1185
> > <https://reviews.apache.org/r/42221/diff/1/?file=1194999#file1194999line1185>
> >
> > s/framwork/frameworks
>
> Alexander Rukletsov wrote:
> Why do you want plural here?
It is just typo, I think that we can fix it here as it does not deserve to file another jira to fix it, comments?
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114126
-----------------------------------------------------------
On 一月 12, 2016, 11:06 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42221/
> -----------------------------------------------------------
>
> (Updated 一月 12, 2016, 11:06 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since wDRF is encapsulated in the choice of sorter, it should not be
> mentioned in the allocator code.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
>
> Diff: https://reviews.apache.org/r/42221/diff/
>
>
> Testing
> -------
>
> `make check` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 42221: Removed references to wDRF from allocator.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114126
-----------------------------------------------------------
Since the comments are mainly to developers, the `second stage` is not very clear to developers, but the `WDRF` seems more clear. If want to update, what about "fair share stage"?
src/master/allocator/mesos/hierarchical.cpp (line 1185)
<https://reviews.apache.org/r/42221/#comment174936>
s/framwork/frameworks
- Guangya Liu
On 一月 12, 2016, 11:06 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42221/
> -----------------------------------------------------------
>
> (Updated 一月 12, 2016, 11:06 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since wDRF is encapsulated in the choice of sorter, it should not be
> mentioned in the allocator code.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
>
> Diff: https://reviews.apache.org/r/42221/diff/
>
>
> Testing
> -------
>
> `make check` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 42221: Removed references to wDRF from allocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Jan. 16, 2016, 10:36 p.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1245
> > <https://reviews.apache.org/r/42221/diff/1/?file=1194999#file1194999line1245>
> >
> > How about `allocatedStage2`?
Good, much shorter with the same meaning.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114886
-----------------------------------------------------------
On Jan. 12, 2016, 11:06 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42221/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 11:06 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since wDRF is encapsulated in the choice of sorter, it should not be
> mentioned in the allocator code.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
>
> Diff: https://reviews.apache.org/r/42221/diff/
>
>
> Testing
> -------
>
> `make check` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 42221: Removed references to wDRF from allocator.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114886
-----------------------------------------------------------
Ship it!
src/master/allocator/mesos/hierarchical.cpp (line 1245)
<https://reviews.apache.org/r/42221/#comment175717>
How about `allocatedStage2`?
- Joris Van Remoortere
On Jan. 12, 2016, 11:06 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42221/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 11:06 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since wDRF is encapsulated in the choice of sorter, it should not be
> mentioned in the allocator code.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
>
> Diff: https://reviews.apache.org/r/42221/diff/
>
>
> Testing
> -------
>
> `make check` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 42221: Removed references to wDRF from allocator.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114213
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 1256)
<https://reviews.apache.org/r/42221/#comment175029>
Not related to this patch, But I think `allocable()` is better than `empty()`.
- Klaus Ma
On Jan. 13, 2016, 7:06 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42221/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 7:06 a.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since wDRF is encapsulated in the choice of sorter, it should not be
> mentioned in the allocator code.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
>
> Diff: https://reviews.apache.org/r/42221/diff/
>
>
> Testing
> -------
>
> `make check` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>