You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2016/06/02 10:20:26 UTC
[GitHub] incubator-zeppelin pull request #951: Move zeppelin version from home page t...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/951
Move zeppelin version from home page to about section
### What is this PR for?
Move zeppelin version that is shown home page to new about section.
### What type of PR is it?
[Improvement]
### Todos
N/A
### What is the Jira issue?
[ZEPPELIN-943](https://issues.apache.org/jira/browse/ZEPPELIN-943)
### How should this be tested?
Please refer the gif below.
### Screenshots (if appropriate)
Before:
After:
Without authentication
With authentication
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/incubator-zeppelin ZEPPELIN-943
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/951.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #951
----
commit eb566c66f19522581faa4a336f19479b5c10ef8b
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2016-06-02T10:11:26Z
Move zeppelin version from home page to about section
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #951: Move zeppelin version from home page t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/951
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #951: Move zeppelin version from home page to about...
Posted by vinayshukla <gi...@git.apache.org>.
Github user vinayshukla commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/951
This is a useful way to find the Zeppelin version number. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #951: Move zeppelin version from home page to about...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/951
Thank you @AhyoungRyu and @Leemoonsoo for the feedback, have implemented.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #951: Move zeppelin version from home page to about...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/951
Thanks for the explanation. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #951: Move zeppelin version from home page to about...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/951
Yes @Leemoonsoo, it was intended. Since, now [Connected/Disconnected] is no more just text its same as one of the action link like Notebook, Interpreter etc. it should share same styling as them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #951: Move zeppelin version from home page to about...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/951
Merging this if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #951: Move zeppelin version from home page to about...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/951
@prabhjyotsingh Big +1 for this improvement! \U0001f44d
This is really minor thing and just my personal opinion, but can we add more space between the connect status circle and the drop-down button ? I think they are too close. What do you think ?
- Without authentication
<img width="208" alt="screen shot 2016-06-02 at 9 56 26 am" src="https://cloud.githubusercontent.com/assets/10060731/15753566/8e2f23f2-28a8-11e6-9326-2defa86fe085.png">
- With authentication
<img width="149" alt="screen shot 2016-06-02 at 9 56 10 am" src="https://cloud.githubusercontent.com/assets/10060731/15753562/88a9b258-28a8-11e6-886c-c739988573dc.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #951: Move zeppelin version from home page to about...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/951
Tested and it looks cool.
It's also my personal preference, to me, moving status circle into dropdown button seems better. And highlight drop down button background color only when cursor hover looks more clean to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #951: Move zeppelin version from home page to about...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/951
Cool. Font size of "Connected" text seems changed. Is it intended?
Before
After
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-zeppelin issue #951: Move zeppelin version
from home page to about...
Posted by moon soo Lee <mo...@apache.org>.
@Jeremy.
If you can participate and share your idea/insight about this small design
discussion [1], that'll be really helpful to the community.
Thanks,
moon
[1]
https://github.com/apache/incubator-zeppelin/pull/951#issuecomment-223355847
On Thu, Jun 2, 2016 at 10:41 AM AhyoungRyu <gi...@git.apache.org> wrote:
> Github user AhyoungRyu commented on the issue:
>
> https://github.com/apache/incubator-zeppelin/pull/951
>
> Regarding **highlight drop down button**, I agree with @Leemoonsoo.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-zeppelin issue #951: Move zeppelin version from home page to about...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/951
Regarding **highlight drop down button**, I agree with @Leemoonsoo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---