[GitHub] [james-project] vttranlina commented on a diff in pull request #1208: CassandraEventStore support removeBefore method for remove old data

[GitBox <gi...@apache.org>]

vttranlina commented on code in PR #1208:
URL: https://github.com/apache/james-project/pull/1208#discussion_r980810789


##########
event-sourcing/event-store-cassandra/src/main/scala/org/apache/james/eventsourcing/eventstore/cassandra/CassandraEventStore.scala:
##########
@@ -38,7 +39,16 @@ class CassandraEventStore @Inject() (eventStoreDao: EventStoreDao) extends Event
 
   private def doAppendAll(events: Iterable[Event]): SMono[Void] = {
     Preconditions.checkArgument(Event.belongsToSameAggregate(events))
-    eventStoreDao.appendAll(events)
+
+    val preconditionPublisher = SFlux.fromIterable(events)

Review Comment:
   This precondition for `CassandraEventStoreTest#appendShouldThrowWhenTryingToRewriteHistory` 
   It will be more heavy when we don't have more table.
   any better idea are welcome



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org