You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Andrew Bloomgarden (JIRA)" <ji...@apache.org> on 2013/10/14 20:20:51 UTC
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just
development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794338#comment-13794338 ]
Andrew Bloomgarden commented on THRIFT-2145:
--------------------------------------------
Note that MongrelHttpServer wasn't being required by thrift.rb, so you didn't need to install Mongrel to use thrift. Since the thin-based server is meant to replace the Mongrel-based one, it should act the same way.
Anyways, this change broke backwards compatibility in a point release. Please fix it, and not by just adding thin as a runtime dependency.
> Rack and Thin are not just development dependencies
> ---------------------------------------------------
>
> Key: THRIFT-2145
> URL: https://issues.apache.org/jira/browse/THRIFT-2145
> Project: Thrift
> Issue Type: Bug
> Components: Ruby - Library
> Affects Versions: 0.9.1
> Environment: Mac OS X and Linux, Ruby v1.9.3
> Reporter: Keith Barrette
> Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch
>
>
> The rack and thin gems should be specified as full dependencies, not just development dependencies.
> This is causing runtime errors when requiring thrift.
--
This message was sent by Atlassian JIRA
(v6.1#6144)