[jira] [Commented] (FLINK-20915) Move docker-entrypoint.sh logic into disrtibution

["Yang Wang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-20915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262353#comment-17262353 ] 

Yang Wang commented on FLINK-20915:
-----------------------------------

I am totally +1 for this efforts. If we could make the {{docker-entrypoint.sh}} in flink-docker project as thin as possible and move the most functionalities into Flink distribution. Then it should be easier for publishing the docker official images.

Based on this, the native K8s mode will have a dedicated entrypoint {{kubernetes-entrypoint.sh}}, which will export some environment variables for internal use.

To avoid divergence of {{docker-entrypoint.sh}} and {{kubernetes-entrypoint.sh}}, I would like jmalloc switch could be an environment setting, not an argument.

 

> Move docker-entrypoint.sh logic into disrtibution
> -------------------------------------------------
>
>                 Key: FLINK-20915
>                 URL: https://issues.apache.org/jira/browse/FLINK-20915
>             Project: Flink
>          Issue Type: Improvement
>          Components: Deployment / Scripts
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.13.0, 1.12.2
>
>
> Copy most of the existing docker-entrypoint.sh into the distribution and defer to it from the docker image. This will make it easier for us to align the distribution and docker entrypoints, hopefully preventing disasters like the 1.12 release.
> The only things remaining in the image are things that are intrinsically tied to the image, like the jmalloc switch.
> Over time we should look into reducing the amount of docker-specific logic in this script.
> For example,
> * setting various config options at startup could be moved into the image creation by modifying flink-conf.yaml right away (in a way, creating a custom docker distribution)
> * docker-specific environment variables (for plugins the the number of slots for task executors) could be supported in all modes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)