Re: [PR] [CELEBORN-1290] Fix NPE occurring prior to worker registration [incubator-celeborn]

["cfmcgrady (via GitHub)" <gi...@apache.org>]

cfmcgrady commented on code in PR #2274:
URL: https://github.com/apache/incubator-celeborn/pull/2274#discussion_r1502063966


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -697,7 +697,7 @@ class PushDataHandler(val workerSource: WorkerSource) extends BaseMessageHandler
     (mapId, attemptId)
   }
 
-  override def checkRegistered(): Boolean = registered.get()
+  override def checkRegistered(): Boolean = registered.map(_.get).getOrElse(false)

Review Comment:
   ```suggestion
     override def checkRegistered(): Boolean = registered.exists(_.get)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org