[GitHub] [superset] AAfghahi commented on a diff in pull request #19694: fix(db & connection): make to show/hide the password when only creating db connection

[GitBox <gi...@apache.org>]

AAfghahi commented on code in PR #19694:
URL: https://github.com/apache/superset/pull/19694#discussion_r849606496


##########
superset-frontend/src/components/Form/LabeledErrorBoundInput.tsx:
##########
@@ -17,7 +17,8 @@
  * under the License.
  */
 import React from 'react';
-import { Input } from 'antd';
+import { Input, Tooltip } from 'antd';

Review Comment:
   Hey we actually should have superset versions of both of these as a superset component, there is a preference towards importing those. I think that might also be true for `EyeOutlined` and `EyeInvisibleOutlined`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org