[GitHub] [pulsar] lovelle commented on a change in pull request #4122: Improve tests for ReaderImpl and ManagedLedgerImpl

[GitBox <gi...@apache.org>]

lovelle commented on a change in pull request #4122: Improve tests for ReaderImpl and ManagedLedgerImpl
URL: https://github.com/apache/pulsar/pull/4122#discussion_r278232539
 
 

 ##########
 File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/TopicReaderTest.java
 ##########
 @@ -554,7 +563,7 @@ public void testReaderIsAbleToSeekWithTimeOnBeginningOfTopic() throws Exception
         producer.close();
     }
 
-    @Test
+    @Test(timeOut = 5000)
 
 Review comment:
   I think 5 secs should be long enough to wait for this test. Do you want to leave it with default value or this explicit 5 secs?
   
   Overall time taken by TopicReaderTests improves by half (from 30 secs to 15 secs in my machine) not so much but is something :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services