You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/01/29 03:54:18 UTC
Review Request 42946: Replace tabs with spaces in configure.ac.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42946/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Replace tabs with spaces in configure.ac.
Diffs
-----
configure.ac cb39c7f
Diff: https://reviews.apache.org/r/42946/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 42946: Replaced tabs with spaces in configure.ac.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42946/#review118142
-----------------------------------------------------------
ping @Joris, any comments on this?
- Klaus Ma
On Jan. 29, 2016, 4:19 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42946/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 4:19 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
>
>
> Bugs: MESOS-4519
> https://issues.apache.org/jira/browse/MESOS-4519
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace tabs with spaces in configure.ac.
>
>
> Diffs
> -----
>
> configure.ac cb39c7f
>
> Diff: https://reviews.apache.org/r/42946/diff/
>
>
> Testing
> -------
>
> ../configure
> make
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 42946: Replaced tabs with spaces in configure.ac.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42946/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 4:19 p.m.)
Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
Changes
-------
Update summary :).
Summary (updated)
-----------------
Replaced tabs with spaces in configure.ac.
Bugs: MESOS-4519
https://issues.apache.org/jira/browse/MESOS-4519
Repository: mesos
Description
-------
Replace tabs with spaces in configure.ac.
Diffs
-----
configure.ac cb39c7f
Diff: https://reviews.apache.org/r/42946/diff/
Testing
-------
../configure
make
Thanks,
Klaus Ma
Re: Review Request 42946: Replace tabs with spaces in configure.ac.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42946/#review116927
-----------------------------------------------------------
Ship it!
Commit message should probably be `s/Replace/Replaced/`.
In addition to building fine we now have
$ egrep ' ' configure.ac | wc -l
0
- Benjamin Bannier
On Jan. 29, 2016, 3:55 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42946/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 3:55 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
>
>
> Bugs: MESOS-4519
> https://issues.apache.org/jira/browse/MESOS-4519
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace tabs with spaces in configure.ac.
>
>
> Diffs
> -----
>
> configure.ac cb39c7f
>
> Diff: https://reviews.apache.org/r/42946/diff/
>
>
> Testing
> -------
>
> ../configure
> make
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 42946: Replace tabs with spaces in configure.ac.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42946/#review116911
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42946]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 29, 2016, 2:55 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42946/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 2:55 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
>
>
> Bugs: MESOS-4519
> https://issues.apache.org/jira/browse/MESOS-4519
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace tabs with spaces in configure.ac.
>
>
> Diffs
> -----
>
> configure.ac cb39c7f
>
> Diff: https://reviews.apache.org/r/42946/diff/
>
>
> Testing
> -------
>
> ../configure
> make
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 42946: Replace tabs with spaces in configure.ac.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42946/#review116914
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Jan. 29, 2016, 2:55 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42946/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 2:55 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
>
>
> Bugs: MESOS-4519
> https://issues.apache.org/jira/browse/MESOS-4519
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace tabs with spaces in configure.ac.
>
>
> Diffs
> -----
>
> configure.ac cb39c7f
>
> Diff: https://reviews.apache.org/r/42946/diff/
>
>
> Testing
> -------
>
> ../configure
> make
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 42946: Replace tabs with spaces in configure.ac.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42946/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 10:55 a.m.)
Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
Changes
-------
Add reviewers.
Bugs: MESOS-4519
https://issues.apache.org/jira/browse/MESOS-4519
Repository: mesos
Description
-------
Replace tabs with spaces in configure.ac.
Diffs
-----
configure.ac cb39c7f
Diff: https://reviews.apache.org/r/42946/diff/
Testing (updated)
-------
../configure
make
Thanks,
Klaus Ma