You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/01/20 00:53:47 UTC

[GitHub] mike-tutkowski commented on a change in pull request #2415: CLOUDSTACK-10244: KVM online storage migration fails and corrupts disk

mike-tutkowski commented on a change in pull request #2415: CLOUDSTACK-10244: KVM online storage migration fails and corrupts disk
URL: https://github.com/apache/cloudstack/pull/2415#discussion_r162765516
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ##########
 @@ -132,8 +132,9 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
             vmsnapshots = libvirtComputingResource.cleanVMSnapshotMetadata(dm);
 
             Map<String, MigrateCommand.MigrateDiskInfo> mapMigrateStorage = command.getMigrateStorage();
+            boolean migrateStorage = MapUtils.isNotEmpty(mapMigrateStorage);
 
 Review comment:
   @wido Sounds good. I can do that and then put the code on the branch that @rhtyd asked.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services