You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2017/03/01 06:39:39 UTC
[kudu-CR] [delete table-test] Disable log compression on some tests
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6200
Change subject: [delete_table-test] Disable log compression on some tests
......................................................................
[delete_table-test] Disable log compression on some tests
Some tests rely on log rolls but with compression enabled these
might take a while. So long that it might trip test timeouts.
I inspected the logs and the test failures this addresses don't
have another visible cause. The log is silent for a full minute
while writes are going on and then the wait fails on a timeout.
This just disables compression in these cases.
Change-Id: I8630cc73f431f5f2e4f567ae02733cdafe073666
---
M src/kudu/integration-tests/delete_table-test.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/6200/1
--
To view, visit http://gerrit.cloudera.org:8080/6200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8630cc73f431f5f2e4f567ae02733cdafe073666
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] [delete table-test] Disable log compression on some tests
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [delete_table-test] Disable log compression on some tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8630cc73f431f5f2e4f567ae02733cdafe073666
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [delete table-test] Disable log compression on some tests
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: [delete_table-test] Disable log compression on some tests
......................................................................
[delete_table-test] Disable log compression on some tests
Some tests rely on log rolls but with compression enabled these
might take a while. So long that it might trip test timeouts.
I inspected the logs and the test failures this addresses don't
have another visible cause. The log is silent for a full minute
while writes are going on and then the wait fails on a timeout.
This just disables compression in these cases.
Change-Id: I8630cc73f431f5f2e4f567ae02733cdafe073666
Reviewed-on: http://gerrit.cloudera.org:8080/6200
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/delete_table-test.cc
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8630cc73f431f5f2e4f567ae02733cdafe073666
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>