[jira] [Commented] (CB-13737) Splash screen images are resized incorrectly on iPhone X

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315368#comment-16315368 ] 

ASF GitHub Bot commented on CB-13737:
-------------------------------------

jcesarmobile opened a new pull request #146: CB-13737 (iOS): fix Splash screen images for iPhone X
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/146
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   ### What does this PR do?
   Takes into account iPhone X sizes for splash screen
   
   ### What testing has been done on this change?
   Tested on iPhone X
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> --------------------------------------------------------
>
>                 Key: CB-13737
>                 URL: https://issues.apache.org/jira/browse/CB-13737
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-splashscreen
>         Environment: iOS 11 / iPhone X
>            Reporter: jcesarmobile
>            Assignee: jcesarmobile
>              Labels: splashscreen
>
> When not using storyboard, the splash images are not correctly resized for iPhone X. So when it switches from the launch image to the splash image there is a noticeable change.
> Also, the landscape image is not displayed, it will show the portrait one.
> {code}
> <splash height="2436" platform="ios" src="res/screens/ios/Default-2436h.png" width="1125" />
> <splash height="1125" platform="ios" src="res/screens/ios/Default-Landscape-2436h.png" width="2436" />
>  {code}       



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org