[PR] GROOVY-11260: ASTMatcher should support matching a var-arg placeholder [groovy]

["paulk-asert (via GitHub)" <gi...@apache.org>]

paulk-asert opened a new pull request, #2022:
URL: https://github.com/apache/groovy/pull/2022

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GROOVY-11260: ASTMatcher should support matching a var-arg placeholder [groovy]

["paulk-asert (via GitHub)" <gi...@apache.org>]

paulk-asert commented on PR #2022:
URL: https://github.com/apache/groovy/pull/2022#issuecomment-1872397053

   It currently doesn't check whether the placeholder names and varargPlaceholder names are distinct. It may not matter but code with such name clashes might become harder to understand, so maybe we should just rule it out.
   
   Also, it currently just matches against all arguments - rather than allowing some normal args followed by the varargs pattern. I'd prefer the latter but it adds much more complexity and the examples where I am using this haven't required this functionality yet. It should be backwards compatible to add such functionality later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GROOVY-11260: ASTMatcher should support matching a var-arg placeholder [groovy]

["paulk-asert (via GitHub)" <gi...@apache.org>]

paulk-asert merged PR #2022:
URL: https://github.com/apache/groovy/pull/2022


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org