You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "gregleleu (via GitHub)" <gi...@apache.org> on 2023/02/28 12:43:10 UTC

[GitHub] [sedona] gregleleu opened a new pull request, #779: [SEDONA-244 & SEDONA-246] R align spark_read/write functions

gregleleu opened a new pull request, #779:
URL: https://github.com/apache/sedona/pull/779

   ## What changes were proposed in this PR?
   In the R package:
   * Split sedona_read|write_* functions returning RDDs and spark_read|write_* functions returning dataframes (R tbl)
   * Add geoparquet and geotiff
   * R package documentation updates
   
   ## How was this patch tested?
   Translated Scala tests for geoparquet and geotiff
   
   ## Did this PR include necessary documentation updates?
   R documentation only
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [sedona] jiayuasu commented on a diff in pull request #779: [SEDONA-244 & SEDONA-246] R align spark_read/write functions

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #779:
URL: https://github.com/apache/sedona/pull/779#discussion_r1120613430


##########
R/apache.sedona.Rproj:
##########
@@ -0,0 +1,17 @@
+Version: 1.0
+

Review Comment:
   Is this a file auto-generated by Rstudio or something else. If so, can you please remove it?



##########
R/R/apache.sedona-package.R:
##########
@@ -0,0 +1,7 @@
+#' @keywords internal

Review Comment:
   Is this needed?



##########
R/DESCRIPTION:
##########
@@ -28,11 +28,14 @@ Depends:
 Imports:
     rlang,
     sparklyr (>= 1.3),

Review Comment:
   In the R folder, can you try to run the following commands? Will it pass without any warning?
   
   ```
   R CMD build .
   R CMD check --as-cran apache.sedona_*.tar.gz
   ```



##########
R/DESCRIPTION:
##########
@@ -1,7 +1,7 @@
 Type: Package
 Package: apache.sedona
 Title: R Interface for Apache Sedona
-Version: 1.3.1

Review Comment:
   Is there a reason why you use 1.3.1.9000?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [sedona] jiayuasu merged pull request #779: [SEDONA-244][SEDONA-246] R align spark_read/write functions

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #779:
URL: https://github.com/apache/sedona/pull/779


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [sedona] gregleleu commented on pull request #779: [SEDONA-244][SEDONA-246] R align spark_read/write functions

Posted by "gregleleu (via GitHub)" <gi...@apache.org>.
gregleleu commented on PR #779:
URL: https://github.com/apache/sedona/pull/779#issuecomment-1448762269

   Also, man pages have so far not been committed to git. Which means i) someone needs to run `devtools::document` before building and ii) that could cause an issue if the "figures" folder is not there (typically it contains the badges). Other projects usually commit man pages.
   
   BTW, the absence of man pages is the reason for one of the warnings in the GH Actions ("Warning: Undocumented code objects:" at the "Check" phase)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [sedona] gregleleu commented on pull request #779: [SEDONA-244][SEDONA-246] R align spark_read/write functions

Posted by "gregleleu (via GitHub)" <gi...@apache.org>.
gregleleu commented on PR #779:
URL: https://github.com/apache/sedona/pull/779#issuecomment-1448769626

   Sure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [sedona] gregleleu commented on a diff in pull request #779: [SEDONA-244][SEDONA-246] R align spark_read/write functions

Posted by "gregleleu (via GitHub)" <gi...@apache.org>.
gregleleu commented on code in PR #779:
URL: https://github.com/apache/sedona/pull/779#discussion_r1120644940


##########
R/R/apache.sedona-package.R:
##########
@@ -0,0 +1,7 @@
+#' @keywords internal

Review Comment:
   This file creates an extra page in the documentation with the description of the package for convenience. (Otherwise, users have to go out of the help).
   It is also used by tools to automate certain package features (here lifecycle management).
   
   See very last paragraph of https://roxygen2.r-lib.org/articles/releases/roxygen2-6.0.0.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [sedona] gregleleu commented on a diff in pull request #779: [SEDONA-244][SEDONA-246] R align spark_read/write functions

Posted by "gregleleu (via GitHub)" <gi...@apache.org>.
gregleleu commented on code in PR #779:
URL: https://github.com/apache/sedona/pull/779#discussion_r1120626655


##########
R/DESCRIPTION:
##########
@@ -1,7 +1,7 @@
 Type: Package
 Package: apache.sedona
 Title: R Interface for Apache Sedona
-Version: 1.3.1

Review Comment:
   R Tidyverse package conventions: 1.3.1 is the latest CRAN version, 1.3.1.9000 is the dev version (similar to 1.4.0-SNAPSHOT) and it will be replaced with 1.4.0 for the release.
   https://r-pkgs.org/lifecycle.html#sec-lifecycle-version-number-tidyverse



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [sedona] gregleleu commented on a diff in pull request #779: [SEDONA-244][SEDONA-246] R align spark_read/write functions

Posted by "gregleleu (via GitHub)" <gi...@apache.org>.
gregleleu commented on code in PR #779:
URL: https://github.com/apache/sedona/pull/779#discussion_r1120672331


##########
R/DESCRIPTION:
##########
@@ -28,11 +28,14 @@ Depends:
 Imports:
     rlang,
     sparklyr (>= 1.3),

Review Comment:
   Both pass without warnings



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [sedona] gregleleu commented on a diff in pull request #779: [SEDONA-244][SEDONA-246] R align spark_read/write functions

Posted by "gregleleu (via GitHub)" <gi...@apache.org>.
gregleleu commented on code in PR #779:
URL: https://github.com/apache/sedona/pull/779#discussion_r1120653982


##########
R/apache.sedona.Rproj:
##########
@@ -0,0 +1,17 @@
+Version: 1.0
+

Review Comment:
   It is a convenience for R users who want to collaborate on/fork the project. It is never included in the final package (ignored at build time). Usually included in tidyverse projects, e.g. https://github.com/sparklyr/sparklyr/blob/main/sparklyr.Rproj
   But I could remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [sedona] jiayuasu commented on pull request #779: [SEDONA-244][SEDONA-246] R align spark_read/write functions

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #779:
URL: https://github.com/apache/sedona/pull/779#issuecomment-1448769064

   Can you create a separate PR to upload the man page? I think this PR is ready to go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org