You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/06 14:17:56 UTC
[GitHub] [hive] belugabehr commented on a change in pull request #1201: HIVE-23797: Throw exception when no metastore found in zookeeper
belugabehr commented on a change in pull request #1201:
URL: https://github.com/apache/hive/pull/1201#discussion_r450251647
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -327,6 +327,13 @@ private void resolveUris() throws MetaException {
MetaStoreUtils.logAndThrowMetaException(e);
}
+ if (metastoreUrisString.isEmpty() && "zookeeper".equalsIgnoreCase(serviceDiscoveryMode)) {
+ throw new MetaException("No metastore server available. "
+ + "Please ensure that at least one metastore server is online");
+ }
+
+ LOG.info("Resolved metastore uris: " + Arrays.toString(metastoreUrisString.toArray()));
Review comment:
Nit:
Do not need to convert it to an array first. This will work:
`LOG.info("Resolved metastore uris: {}", metastoreUrisString);`
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -327,6 +327,13 @@ private void resolveUris() throws MetaException {
MetaStoreUtils.logAndThrowMetaException(e);
}
+ if (metastoreUrisString.isEmpty() && "zookeeper".equalsIgnoreCase(serviceDiscoveryMode)) {
+ throw new MetaException("No metastore server available. "
Review comment:
Please add some additional context here regarding ZooKeeper. Something like:
`No metastore store service discovered in ZooKeeper`
or
`No metastore store service currently registered in ZookKeeper`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org