[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6027: Support streaming query in QueryExecutor

[GitBox <gi...@apache.org>]

fx19880617 commented on a change in pull request #6027:
URL: https://github.com/apache/incubator-pinot/pull/6027#discussion_r490604509



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/executor/QueryExecutor.java
##########
@@ -54,6 +55,16 @@ void init(PinotConfiguration config, InstanceDataManager instanceDataManager, Se
 
   /**
    * Processes the query with the given executor service.
+   * <ul>
+   *   <li>
+   *     For streaming request, the returned DataTable contains only the metadata. The response is streamed back via the
+   *     observer.
+   *   </li>
+   *   <li>
+   *     For non-streaming request, the returned DataTable contains both data and metadata.
+   *   </li>
+   * </ul>
    */
-  DataTable processQuery(ServerQueryRequest queryRequest, ExecutorService executorService);
+  DataTable processQuery(ServerQueryRequest queryRequest, ExecutorService executorService,

Review comment:
       Shall we have a different QueryExecutor implementation for streaming request rather than change this method in the interface?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org