You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "featzhang (via GitHub)" <gi...@apache.org> on 2023/03/28 15:26:01 UTC
[GitHub] [inlong] featzhang opened a new pull request, #7718: [INLONG-7711][Sort][Manager] Support specifying parameters for the kudu client
featzhang opened a new pull request, #7718:
URL: https://github.com/apache/inlong/pull/7718
### Prepare a Pull Request
*[INLONG-7711][Sort][Manager] Support specifying parameters for the kudu client*
- Fixes #7711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7718: [INLONG-7711][Sort][Manager] Support specifying parameters for the kudu client
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7718:
URL: https://github.com/apache/inlong/pull/7718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7718: [INLONG-7711][Sort][Manager] Support specifying parameters for the kudu client
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7718:
URL: https://github.com/apache/inlong/pull/7718#discussion_r1151334285
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/kudu/KuduDataNodeDTO.java:
##########
@@ -47,10 +47,10 @@ public class KuduDataNodeDTO {
@ApiModelProperty("Kudu masters, a comma separated list of 'host:port' pairs")
private String masters;
- @ApiModelProperty("Default admin operation timeout in ms, default is 3000")
+ @ApiModelProperty("Default admin operation timeout in ms, default is 30000")
private Integer defaultAdminOperationTimeoutMs;
Review Comment:
Does this param need a default value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7718: [INLONG-7711][Sort][Manager] Support specifying parameters for the kudu client
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7718:
URL: https://github.com/apache/inlong/pull/7718#discussion_r1151334045
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/kudu/KuduDataNodeDTO.java:
##########
@@ -47,10 +47,10 @@ public class KuduDataNodeDTO {
@ApiModelProperty("Kudu masters, a comma separated list of 'host:port' pairs")
private String masters;
- @ApiModelProperty("Default admin operation timeout in ms, default is 3000")
+ @ApiModelProperty("Default admin operation timeout in ms, default is 30000")
private Integer defaultAdminOperationTimeoutMs;
- @ApiModelProperty("Default operation timeout in ms, default is 3000")
+ @ApiModelProperty("Default operation timeout in ms, default is 30000")
private Integer defaultOperationTimeoutMs = 3000;
Review Comment:
Please change `3000` to `30000`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org