You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/10/21 22:43:59 UTC

[kudu-CR] MiniKdc for Java 

Hello Jean-Daniel Cryans, Todd Lipcon, Alexey Serbin,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4788

to review the following change.

Change subject: MiniKdc for Java
......................................................................

MiniKdc for Java

Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
---
A java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java
M src/kudu/security/mini_kdc.cc
3 files changed, 374 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4788/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] MiniKdc for Java

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: MiniKdc for Java
......................................................................


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] MiniKdc for Java

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: MiniKdc for Java
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4788/2/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java:

PS2, Line 318: LOG.trace("executing {}: {}", Paths.get(argv[0]).getFileName(), Joiner.on(' ').join(args));
> There are calls to buildProcessWithKrbEnv that don't go through startProces
Ah, I see.  The message looked misleading to me since I saw it was not executing the binary right here.  But if it's good enough, that's fine.


PS2, Line 329: Process process, String name
> Maybe, but I think it would be a lot of boilerplate just to avoid a single 
ok, that sounds reasonable.


http://gerrit.cloudera.org:8080/#/c/4788/2/src/kudu/security/mini_kdc.cc
File src/kudu/security/mini_kdc.cc:

PS2, Line 128: RETURN_NOT_OK(Env::Default()->CreateDir(options_.data_root));
Nit: it seems this directory is kind of synchronization point between Java MiniKDC and C++ MiniKDC.  However, what if an error encountered while creating files in the directory?

Also, what if the directory has just been created by the concurrent Java MiniKDC, then it might be a race to complete writing configs and reading them.

Besides, the scheme (try to create if not exist) is racy.  May be, just try to create a directory and then check for the status code (like if it's Status::AlreadyPresent, then back off)?


-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] MiniKdc for Java

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4788

to look at the new patch set (#4).

Change subject: MiniKdc for Java
......................................................................

MiniKdc for Java

Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
---
A java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java
M src/kudu/security/mini_kdc.cc
3 files changed, 413 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4788/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] MiniKdc for Java

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.

Change subject: MiniKdc for Java
......................................................................


MiniKdc for Java

Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Reviewed-on: http://gerrit.cloudera.org:8080/4788
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
A java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java
M src/kudu/security/mini_kdc.cc
3 files changed, 413 insertions(+), 10 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] MiniKdc for Java

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4788

to look at the new patch set (#2).

Change subject: MiniKdc for Java
......................................................................

MiniKdc for Java

Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
---
A java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java
M src/kudu/security/mini_kdc.cc
3 files changed, 411 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4788/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] MiniKdc for Java

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: MiniKdc for Java
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4788/2/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java:

PS2, Line 54: 64530
How did you pick this value?


Line 125:     if (!dataRootDir.exists()) {
Hmm, so if the data root exists, we'll try to reuse the KDB and configs that are in there? Is that what the C++ implementation does too?


Line 274:   public void close() throws IOException {
Can you consolidate the stop() and close() implementations?


Line 281:       FileUtils.deleteDirectory(options.dataRoot.toFile());
I think this belongs in the finally clause.


-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] MiniKdc for Java

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: MiniKdc for Java
......................................................................


Patch Set 2:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/4788/2/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java:

PS2, Line 54: 64530
> How did you pick this value?
It's offset by 500 from MiniKuduCluster.PORT_START.  I don't know the provenance of MiniKuduCluster.PORT_START.


Line 125:     if (!dataRootDir.exists()) {
> Hmm, so if the data root exists, we'll try to reuse the KDB and configs tha
Yes.  This is to support start/stop/start of a single KDC.


Line 274:   public void close() throws IOException {
> Can you consolidate the stop() and close() implementations?
Done


Line 281:       FileUtils.deleteDirectory(options.dataRoot.toFile());
> I think this belongs in the finally clause.
Done


PS2, Line 318: LOG.trace("executing {}: {}", Paths.get(argv[0]).getFileName(), Joiner.on(' ').join(args));
> Consider moving this log line into startProcessWithKrbEnv() method.
There are calls to buildProcessWithKrbEnv that don't go through startProcessWithKrbEnv that it's helpful to log.


PS2, Line 329: Process process, String name
> Would it make sense to make a sub-class of the Process class, so it would b
Maybe, but I think it would be a lot of boilerplate just to avoid a single parameter to a private method.


-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] MiniKdc for Java

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: MiniKdc for Java
......................................................................


Patch Set 3: Code-Review+1

Looks OK to me but I'll defer to Alexey/JD.

-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] MiniKdc for Java

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: MiniKdc for Java
......................................................................


Patch Set 1:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4788/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java:

Line 1: package org.apache.kudu.client;
Missing license.


PS1, Line 28: An
nit: A


Line 30:  */
Maybe explain how this class works? Like it uses external processes for about everything, how it does it, etc.


PS1, Line 132: potentially race
nit: race-prone?


PS1, Line 178: C
nit: c


Line 322:   private static String getBinaryPath(String executable, List<String> searchPaths) throws IOException {
nit: long line


http://gerrit.cloudera.org:8080/#/c/4788/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java:

Line 1: package org.apache.kudu.client;
Missing license.


-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] MiniKdc for Java

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4788

to look at the new patch set (#3).

Change subject: MiniKdc for Java
......................................................................

MiniKdc for Java

Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
---
A java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java
M src/kudu/security/mini_kdc.cc
3 files changed, 407 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4788/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] MiniKdc for Java

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: MiniKdc for Java
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4788/2/src/kudu/security/mini_kdc.cc
File src/kudu/security/mini_kdc.cc:

PS2, Line 128: RETURN_NOT_OK(Env::Default()->CreateDir(options_.data_root));
> Nit: it seems this directory is kind of synchronization point between Java 
The Java and C++ MiniKdc instances will not share a directory.  Each instance gets a unique directory.

The MiniKdc is not meant to be shared, so this method doesn't account for concurrency.  The check is just to see if this MiniKdc has previously been started, or if this is the first time.


-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] MiniKdc for Java

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: MiniKdc for Java
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4788/2/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java:

PS2, Line 318: LOG.trace("executing {}: {}", Paths.get(argv[0]).getFileName(), Joiner.on(' ').join(args));
Consider moving this log line into startProcessWithKrbEnv() method.


PS2, Line 329: Process process, String name
Would it make sense to make a sub-class of the Process class, so it would be possible to retrieve command-line/name?  That would allow to get rid of the second parameter.


-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] MiniKdc for Java

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: MiniKdc for Java
......................................................................


Patch Set 1:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4788/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java:

Line 1: package org.apache.kudu.client;
> Missing license.
Done


PS1, Line 28: An
> nit: A
Done


Line 30:  */
> Maybe explain how this class works? Like it uses external processes for abo
Done


PS1, Line 132: potentially race
> nit: race-prone?
Done


PS1, Line 178: C
> nit: c
Done


Line 322:   private static String getBinaryPath(String executable, List<String> searchPaths) throws IOException {
> nit: long line
Done


http://gerrit.cloudera.org:8080/#/c/4788/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java:

Line 1: package org.apache.kudu.client;
> Missing license.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes