You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Glen Mazza <gl...@verizon.net> on 2007/09/14 21:17:35 UTC
Re: svn commit: r575516 - in /incubator/cxf/trunk/tools/validator/src:
main/java/org/apache/cxf/tools/validator/internal/
test/java/org/apache/cxf/tools/validator/ test/resources/validator_wsdl/
Am Freitag, den 14.09.2007, 02:44 +0000 schrieb mmao@apache.org:
> Author: mmao
> Date: Thu Sep 13 19:44:07 2007
> New Revision: 575516
>
> URL: http://svn.apache.org/viewvc?rev=575516&view=rev
> Log:
> CXF-996
> * If there's no binding style, it's DOCUMENT
> * Add tests for WSI-BP R2717
>
>
> Added:
> incubator/cxf/trunk/tools/validator/src/test/resources/validator_wsdl/bp2717.wsdl
> incubator/cxf/trunk/tools/validator/src/test/resources/validator_wsdl/cxf996.wsdl
> Modified:
> incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java
> incubator/cxf/trunk/tools/validator/src/test/java/org/apache/cxf/tools/validator/WSDLValidationTest.java
>
> Modified: incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java
> URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java?rev=575516&r1=575515&r2=575516&view=diff
> ==============================================================================
> --- incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java (original)
> +++ incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSIBPValidator.java Thu Sep 13 19:44:07 2007
> @@ -247,10 +247,9 @@
> BindingOperation bop = wsdlHelper.getBindingOperation(def, operation.getName());
> Binding binding = wsdlHelper.getBinding(bop, def);
> String bindingStyle = binding != null ? SOAPBindingUtil.getBindingStyle(binding) : "";
> -
> String style = "".equals(SOAPBindingUtil.getSOAPOperationStyle(bop))
> ? bindingStyle : SOAPBindingUtil.getSOAPOperationStyle(bop);
> - if ("DOCUMENT".equalsIgnoreCase(style)) {
> + if ("DOCUMENT".equalsIgnoreCase(style) || "".equals(style)) {
Just to confirm, are you sure case-insensitivity is needed here?
Glen
Re: svn commit: r575516 - in /incubator/cxf/trunk/tools/validator/src:
main/java/org/apache/cxf/tools/validator/internal/ test/java/org/apache/cxf/tools/validator/
test/resources/validator_wsdl/
Posted by James Mao <ja...@iona.com>.
To be honest, I really don't like the hard coded strings all over the
place,
they should be in one place and should be a constants,
Will Revisit those equals latter
James
>> - if ("DOCUMENT".equalsIgnoreCase(style)) {
>> + if ("DOCUMENT".equalsIgnoreCase(style) || "".equals(style)) {
>>
>
> Just to confirm, are you sure case-insensitivity is needed here?
>
> Glen
>
>
>