You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/15 09:28:17 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #38605: [SPARK-41103][CONNECT][DOC] Document how to add a new proto field of messages

cloud-fan commented on code in PR #38605:
URL: https://github.com/apache/spark/pull/38605#discussion_r1022545314


##########
connector/connect/docs/adding-proto-messages.md:
##########
@@ -0,0 +1,41 @@
+# Required, Optional and default values
+
+Connect adopts proto3, which does not support `required` constraint anymore. 

Review Comment:
   ```suggestion
   Spark Connect adopts proto3, which does not support `required` constraint anymore. 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org