You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/05 09:31:01 UTC

[GitHub] [arrow] cyb70289 commented on a change in pull request #7903: ARROW-9643: [C++] Only register the SIMD variants when it's supported.

cyb70289 commented on a change in pull request #7903:
URL: https://github.com/apache/arrow/pull/7903#discussion_r465597132



##########
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##########
@@ -396,11 +397,16 @@ void RegisterScalarAggregateBasic(FunctionRegistry* registry) {
   aggregate::AddBasicAggKernels(aggregate::SumInit, FloatingPointTypes(), float64(),
                                 func.get());
   // Add the SIMD variants for sum
+  auto cpu_info = arrow::internal::CpuInfo::GetInstance();
 #if defined(ARROW_HAVE_RUNTIME_AVX2)

Review comment:
       Is it possible to drop these #ifdef ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org