You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/06/30 07:09:25 UTC
[kudu-CR] add table name field to GetTableSchemaResponsePB
Hello Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3542
to review the following change.
Change subject: add table name field to GetTableSchemaResponsePB
......................................................................
add table name field to GetTableSchemaResponsePB
It is possible for clients to send a GetTableSchema RPC with only the table ID
specified, in which case it is useful to have the table name as part of the
response (in case the client does not know it).
Change-Id: I30c4742274f8946794f6af0f407c8a63804cece6
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master.proto
3 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/3542/1
--
To view, visit http://gerrit.cloudera.org:8080/3542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30c4742274f8946794f6af0f407c8a63804cece6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] add table name field to GetTableSchemaResponsePB
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: add table name field to GetTableSchemaResponsePB
......................................................................
add table name field to GetTableSchemaResponsePB
It is possible for clients to send a GetTableSchema RPC with only the table ID
specified, in which case it is useful to have the table name as part of the
response (in case the client does not know it).
Change-Id: I30c4742274f8946794f6af0f407c8a63804cece6
Reviewed-on: http://gerrit.cloudera.org:8080/3542
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master.proto
3 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30c4742274f8946794f6af0f407c8a63804cece6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] add table name field to GetTableSchemaResponsePB
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: add table name field to GetTableSchemaResponsePB
......................................................................
Patch Set 1:
For a hypothetical client which allows opening tables by ID.
--
To view, visit http://gerrit.cloudera.org:8080/3542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30c4742274f8946794f6af0f407c8a63804cece6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] add table name field to GetTableSchemaResponsePB
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: add table name field to GetTableSchemaResponsePB
......................................................................
Patch Set 1: Code-Review+2
Looks fine, but what do you need this for? AFAIK the client code requires table names everywhere.
--
To view, visit http://gerrit.cloudera.org:8080/3542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30c4742274f8946794f6af0f407c8a63804cece6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] add table name field to GetTableSchemaResponsePB
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: add table name field to GetTableSchemaResponsePB
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2113/
--
To view, visit http://gerrit.cloudera.org:8080/3542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30c4742274f8946794f6af0f407c8a63804cece6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No