You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by "Sam Ruby (Jira)" <ji...@apache.org> on 2020/09/20 13:47:00 UTC
[jira] [Commented] (WHIMSY-341) Use of RACK_ENV for Whimsy
customisation
[ https://issues.apache.org/jira/browse/WHIMSY-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198998#comment-17198998 ]
Sam Ruby commented on WHIMSY-341:
---------------------------------
While the origin of RACK_ENV is unquestionably derived from rack usage, its usage has gone well beyond rack. As an example, the de facto way to determine if one is running in a test environment is to check if RACK_ENV is "test" . See, for example, [https://docs.travis-ci.com/user/environment-variables/]
> Use of RACK_ENV for Whimsy customisation
> ----------------------------------------
>
> Key: WHIMSY-341
> URL: https://issues.apache.org/jira/browse/WHIMSY-341
> Project: Whimsy
> Issue Type: Bug
> Reporter: Sebb
> Priority: Major
>
> The RACK_ENV variable is being used for purposes for which it was not intended.
> For example, logging level and use of local test data overrides.
> It should not be used for anything other than a Rack application.
> It would be much less fragile to use a WHIMSY_ prefix for variables that relate to the Whimsy application.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)