You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Daniel Estévez <no...@github.com> on 2018/05/11 21:33:04 UTC

[jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

To avoid problems with the cache, and specifically running the AzureComputeImageExtensionLiveTest suite.

ARM is quite slow and it takes usually more than one minute (default value) for certain operations. The testImageIsCachedAfterBeingCreated in that suite fails often since it takes longer than one minute to destroy the created node in testCreateImage and cache does not contain the image.

It should be safe to increase this value in the provider metadata. 5 minutes looks good but open to discuss

Would be good to add this also to https://github.com/danielestevez/jclouds/blob/83c0a3c7b255ec744c6150ce76c40e8301280c79/providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/internal/AzureLiveTestUtils.java ?


You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1206

-- Commit Summary --

  * Sets session interval from 60 seconds to a higher value to avoid problems with cache

-- File Changes --

    M providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/AzureComputeProviderMetadata.java (1)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1206.patch
https://github.com/jclouds/jclouds/pull/1206.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1206

Re: [jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

Posted by Andrew Phillips <no...@github.com>.

demobox commented on this pull request.



> @@ -90,6 +91,7 @@ public static Properties defaultProperties() {
       properties.put(TIMEOUT_NODE_TERMINATED, 60 * 10 * 1000);
       // Default max wait in rate limit: 5m30s
       properties.put(PROPERTY_MAX_RATE_LIMIT_WAIT, 330000);
+      properties.put(PROPERTY_SESSION_INTERVAL, 300);

[minor] Any kind of comment we can add here to motivate 5min as the setting?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1206#pullrequestreview-119627690

Re: [jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

Posted by Andrew Phillips <no...@github.com>.

Added one minor comment - thanks for the contribution, Daniel!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1206#issuecomment-388558647

Re: [jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

Posted by Ignasi Barrera <no...@github.com>.

>Would be good to add this also to https://github.com/danielestevez/jclouds/blob/83c0a3c7b255ec744c6150ce76c40e8301280c79/providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/internal/AzureLiveTestUtils.java ?

That class just adds *overrides* for default provider properties, so as long as you put the right default in the provider metadata there is no need to also configure it in the tests.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1206#issuecomment-388497463

Re: [jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

Posted by Ignasi Barrera <no...@github.com>.

Closed #1206.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1206#event-1622909006

Re: [jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

Posted by Daniel Estévez <no...@github.com>.

Sorry about that, fixed

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1206#issuecomment-388499413

Re: [jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

Posted by Ignasi Barrera <no...@github.com>.

>It should be safe to increase this value in the provider metadata. 5 minutes looks good but open to discuss

Looks like a sane default.

Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a08de5b2) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/491911ec). Thanks @danielestevez!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1206#issuecomment-388503523

Re: [jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

Posted by Ignasi Barrera <no...@github.com>.

The build failed. It looks like there's a missing static import.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1206#issuecomment-388498018