You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/21 19:21:47 UTC

[GitHub] vandanavk commented on a change in pull request #13356: [WIP] ONNX export: Add Flatten before Gemm

vandanavk commented on a change in pull request #13356: [WIP] ONNX export: Add Flatten before Gemm
URL: https://github.com/apache/incubator-mxnet/pull/13356#discussion_r235512670
 
 

 ##########
 File path: python/mxnet/contrib/onnx/mx2onnx/export_onnx.py
 ##########
 @@ -294,7 +298,7 @@ def create_onnx_graph_proto(self, sym, params, in_shape, in_type, verbose=False)
                     # If converted node is NodeProto, add it in processed nodes list
                     elif isinstance(converted_node, NodeProto):
                         onnx_processed_nodes.append(converted_node)
-                        if idx == (len(mx_graph) - 1):
+                        if converted_node.name in output_names:
 
 Review comment:
   This needs modification for cases when there is no converted_node.name - working on this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services