You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/05/21 15:57:51 UTC

[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #15002: Safe LayerNorm

eric-haibin-lin commented on a change in pull request #15002: Safe LayerNorm
URL: https://github.com/apache/incubator-mxnet/pull/15002#discussion_r286101591
 
 

 ##########
 File path: src/operator/nn/layer_norm-inl.h
 ##########
 @@ -116,7 +116,7 @@ void LayerNormComputeGeneral(const nnvm::NodeAttrs& attrs,
   // Calculate mean
   MSHADOW_REAL_TYPE_SWITCH(outputs[0].type_flag_, DType, {
     BROADCAST_NDIM_SWITCH(red_dst_shape.ndim(), NDim, {
-      broadcast::Reduce<red::sum, NDim, DType, op::mshadow_op::identity>(
+      broadcast::Reduce<mshadow_op::sum, NDim, DType, mshadow_op::identity, true>(
 
 Review comment:
   Should we read env var first before setting safe_acc to `True`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services