You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Louis Xu (JIRA)" <ji...@apache.org> on 2019/07/23 07:44:00 UTC
[jira] [Commented] (FLINK-13378) Wrong comment in
SingleValueAggFunction.accumulateExpressions()
[ https://issues.apache.org/jira/browse/FLINK-13378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890745#comment-16890745 ]
Louis Xu commented on FLINK-13378:
----------------------------------
[~jark] [~lzljs3620320] What do you think? Do you ever post some material describe this.
> Wrong comment in SingleValueAggFunction.accumulateExpressions()
> ---------------------------------------------------------------
>
> Key: FLINK-13378
> URL: https://issues.apache.org/jira/browse/FLINK-13378
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
> Affects Versions: 1.9.0, 1.10.0
> Reporter: Louis Xu
> Priority: Major
> Fix For: 1.10.0
>
>
> 1.The comment in the method is "value = count == 0 ? exception : operand(0)", but actually it need to be "value = count > 0 ? exception : operand(0)" according to the code and logic.
> 2.And the "throwException" expression's parameter msg is never used. And if we only think about "throwException" expression, the param "type" is the return type of agg function or msg's type? I don't known the definition of "throwException" expression, but I think this might be some problem.
> 3.If we need use param msg, the expression is call(THROW_EXCEPTION, literal(msg, type)) or
> call(THROW_EXCEPTION, literal(msg), typeLiteral(type)).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)