You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/01 19:12:56 UTC
[GitHub] [arrow] abandy opened a new pull request, #14561: Initial swift arrow impl
abandy opened a new pull request, #14561:
URL: https://github.com/apache/arrow/pull/14561
Initial check-in for a swift implementation of Arrow. Based on my understanding of the spec and looking through the C++ and C# current implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14561: Initial swift arrow impl
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1299047179
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1095742256
##########
ci/docker/ubuntu-swift.dockerfile:
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+FROM swift:5.7.3
+
+RUN apt-get update -y -q && \
+ apt-get clean
Review Comment:
Nice, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1095225694
##########
ci/docker/ubuntu-swift.dockerfile:
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+FROM swift:5.7.3
+
+RUN apt-get update -y -q && \
+ apt-get clean
Review Comment:
I removed the RUN command. I tried using swift:5.7.3 in the docker-compose file but it fails as it requires a url to the repo I believe. Looks like the from in the swift.dockerfile is able to resolve the url without having to hard code it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1302957408
Great!
Can we add a basic CI job for this implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1087365955
##########
swift/Arrow/Package.swift:
##########
@@ -0,0 +1,23 @@
+// swift-tools-version:5.5
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+
+import PackageDescription
+
+let package = Package(
Review Comment:
It would be more inline with go. Packages are included using git url and tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1086546084
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ ubuntu:
+ - 20.04
+ env:
+ UBUNTU: ${{ matrix.ubuntu }}
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Cache Docker Volumes
+ uses: actions/cache@v3
+ with:
+ path: .docker
+ key: ${{ matrix.cache }}-${{ hashFiles('swift/**') }}
+ restore-keys: ${{ matrix.cache }}-
+ - name: Setup Archery
+ run: pip install -e dev/archery[docker]
+ - name: Execute Docker Build
+ env:
+ ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
+ ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
+ run: |
+ sudo sysctl -w kernel.core_pattern="core.%e.%p"
+ ulimit -c unlimited
+ archery docker run ${{ matrix.image }}
Review Comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1087367414
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,79 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
Review Comment:
Will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on pull request #14561: ARROW-18234: [Archery] Initial swift arrow impl
Posted by GitBox <gi...@apache.org>.
abandy commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1301485251
I do not believe the component is correct but was unable to find Swift or a suitable alternative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1085387406
##########
.dockerignore:
##########
@@ -62,4 +62,5 @@
!rust/datafusion/benches
!rust/integration-testing/Cargo.toml
!go/go.mod
-!go/go.sum
\ No newline at end of file
+!go/go.sum
+!swift/Arrow
Review Comment:
Ok, will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1084330482
##########
.dockerignore:
##########
@@ -62,4 +62,5 @@
!rust/datafusion/benches
!rust/integration-testing/Cargo.toml
!go/go.mod
-!go/go.sum
\ No newline at end of file
+!go/go.sum
+!swift/Arrow
Review Comment:
Gocha, will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1083337552
##########
docker-compose.yml:
##########
@@ -1400,7 +1423,8 @@ services:
ARROW_R_DEV: "true"
volumes: *ubuntu-volumes
command: >
- /bin/bash -c "/arrow/ci/scripts/r_revdepcheck.sh /arrow"
+ /bin/bash -c "
+ /arrow/ci/scripts/r_revdepcheck.sh /arrow"
Review Comment:
Could you revert this?
##########
.dockerignore:
##########
@@ -62,4 +62,5 @@
!rust/datafusion/benches
!rust/integration-testing/Cargo.toml
!go/go.mod
-!go/go.sum
\ No newline at end of file
+!go/go.sum
+!swift/Arrow
Review Comment:
I think that this is needless because this is not used in Dockerfile. We can access `swift/Arrow` in `docker run` because we mount the source directory to `/arrow` in `docker run`.
##########
swift/Arrow/Package.swift:
##########
@@ -0,0 +1,23 @@
+// swift-tools-version:5.5
+// The swift-tools-version declares the minimum version of Swift required to build this package.
Review Comment:
Could you add license header?
##########
ci/docker/linux-apt-swift.dockerfile:
##########
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ARG base
+FROM ${base}
+
+ADD swift/ /arrow/swift
+RUN apt-get update -y -q && \
+ apt-get install -y -q \
+ binutils \
+ git \
+ gnupg2 \
+ libc6-dev \
+ libcurl4 \
+ libedit2 \
+ libgcc-9-dev \
+ libpython2.7 \
+ libsqlite3-0 \
+ libstdc++-9-dev \
+ libxml2 \
+ libz3-dev \
+ pkg-config \
+ tzdata \
+ zlib1g-dev \
+ wget && \
+ apt-get clean && \
+ wget https://download.swift.org/swift-5.7.1-release/ubuntu2004/swift-5.7.1-RELEASE/swift-5.7.1-RELEASE-ubuntu20.04.tar.gz
+
+RUN tar -xvzf swift-5.7.1-RELEASE-ubuntu20.04.tar.gz
+ENV PATH=/swift-5.7.1-RELEASE-ubuntu20.04/usr/bin:$PATH
Review Comment:
```suggestion
ubuntu_version=$(. /etc/os-release && echo ${VERSION_ID}) && \
ubuntu_version_no-dot=$(echo ${ubuntu_version} | sed -e 's/\.//g')
wget https://download.swift.org/swift-5.7.3-release/ubuntu${ubuntu_version_no_dot}/swift-5.7.3-RELEASE/swift-5.7.3-RELEASE-ubuntu${ubuntu_version}.tar.gz && \
tar -xvzf swift-5.7.3-RELEASE-ubuntu${ubuntu_version}.tar.gz && \
rm swift-5.7.3-RELEASE-ubuntu${ubuntu_version}.tar.gz && \
mv swift-5.7.3-RELEASE-ubuntu${ubuntu_version} /swift
ENV PATH=/swift/usr/bin:$PATH
```
##########
swift/Arrow/README.md:
##########
@@ -0,0 +1,49 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Apache Arrow
Review Comment:
How about adding "Swift" such as "Apache Arrow Swift"?
```suggestion
# Apache Arrow Swift
```
##########
docker-compose.yml:
##########
@@ -869,6 +870,28 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-cpp
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-swift
+ build:
+ context: .
+ dockerfile: ci/docker/linux-apt-swift.dockerfile
+ args:
+ base: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-cpp
Review Comment:
Do we need to use `ubuntu-cpp` as base image?
Should we use a Swift's Docker image instead? https://hub.docker.com/_/swift/?tab=tags
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ env:
+ UBUNTU: ${{ matrix.ubuntu || 20.04 }}
Review Comment:
It seems that `matrix.ubuntu` isn't defined.
```suggestion
env:
UBUNTU: ${{ matrix.ubuntu || 20.04 }}
```
##########
swift/Arrow/README.md:
##########
@@ -0,0 +1,49 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Apache Arrow
+
+An implementation of Arrow targeting Swift.
+
+# Status
Review Comment:
```suggestion
## Status
```
The following headings should have one more `#` too.
##########
swift/Arrow/Package.swift:
##########
@@ -0,0 +1,23 @@
+// swift-tools-version:5.5
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+
+import PackageDescription
+
+let package = Package(
Review Comment:
Can we specify package license?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1411581763
We can merge this after we remove needless Ubuntu versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1086545755
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ ubuntu:
+ - 20.04
+ env:
+ UBUNTU: ${{ matrix.ubuntu }}
Review Comment:
Will do.
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ ubuntu:
+ - 20.04
+ env:
+ UBUNTU: ${{ matrix.ubuntu }}
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Cache Docker Volumes
+ uses: actions/cache@v3
+ with:
+ path: .docker
+ key: ${{ matrix.cache }}-${{ hashFiles('swift/**') }}
+ restore-keys: ${{ matrix.cache }}-
Review Comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by GitBox <gi...@apache.org>.
abandy commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1375872463
I have been working on the swift arrow IPC impl to add to this PR. Are there any test files in the arrow repo that I can use to test an IPC reader/writer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1085629936
##########
swift/Arrow/Package.swift:
##########
@@ -0,0 +1,23 @@
+// swift-tools-version:5.5
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+
+import PackageDescription
+
+let package = Package(
Review Comment:
I see what you mean. I have looked at some other repos and the Package documentation and it doesn't look like the Package.swift file contains any licensing info besides the one included in the header.
Once this PR has been merged, I will look at registering this package in https://swiftpackageregistry.com.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1086146874
##########
docker-compose.yml:
##########
@@ -869,6 +870,25 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-swift
+ build:
+ context: .
+ dockerfile: ci/docker/linux-apt-swift.dockerfile
Review Comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1086547439
##########
docker-compose.yml:
##########
@@ -141,6 +141,7 @@ x-hierarchy:
- ubuntu-python-sdist-test
- ubuntu-r
- ubuntu-r-only-r
+ - ubuntu-swift
Review Comment:
I see, I will move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1086143018
##########
ci/docker/linux-apt-swift.dockerfile:
##########
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+FROM swift:5.7.3
+
+RUN apt-get update -y -q && \
+ apt-get install -y -q \
+ binutils \
+ git \
+ gnupg2 \
+ libc6-dev \
+ libcurl4 \
+ libedit2 \
+ libgcc-9-dev \
+ libpython2.7 \
+ libsqlite3-0 \
+ libstdc++-9-dev \
+ libxml2 \
+ libz3-dev \
+ pkg-config \
+ tzdata \
+ zlib1g-dev \
+ wget && \
+ apt-get clean && \
+ ubuntu_version=$(. /etc/os-release && echo ${VERSION_ID}) && \
+ ubuntu_version_no_dot=$(echo ${ubuntu_version} | sed -e 's/\.//g') && \
+ wget https://download.swift.org/swift-5.7.3-release/ubuntu${ubuntu_version_no_dot}/swift-5.7.3-RELEASE/swift-5.7.3-RELEASE-ubuntu${ubuntu_version}.tar.gz && \
+ tar -xvzf swift-5.7.3-RELEASE-ubuntu${ubuntu_version}.tar.gz && \
+ rm swift-5.7.3-RELEASE-ubuntu${ubuntu_version}.tar.gz && \
+ mv swift-5.7.3-RELEASE-ubuntu${ubuntu_version} /swift
Review Comment:
Makes sense :), will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1086142183
##########
swift/Arrow/Package.swift:
##########
@@ -0,0 +1,23 @@
+// swift-tools-version:5.5
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+
+import PackageDescription
+
+let package = Package(
Review Comment:
Gotcha, thanks for letting me know.
##########
.dockerignore:
##########
@@ -61,5 +61,4 @@
!rust/datafusion/Cargo.toml
!rust/datafusion/benches
!rust/integration-testing/Cargo.toml
-!go/go.mod
-!go/go.sum
\ No newline at end of file
+!go/go.mod
Review Comment:
Makes sense, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1410583586
Is it possible to get this approved soon (so I can start on adding the IPC reader/writer)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1093987119
##########
docker-compose.yml:
##########
@@ -870,6 +871,23 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1084980697
##########
.dockerignore:
##########
@@ -62,4 +62,5 @@
!rust/datafusion/benches
!rust/integration-testing/Cargo.toml
!go/go.mod
-!go/go.sum
\ No newline at end of file
+!go/go.sum
+!swift/Arrow
Review Comment:
We can remove `ADD swift/ /arrow/swift` because we mount `swift/` in `docker run`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1086138286
##########
swift/Arrow/Package.swift:
##########
@@ -0,0 +1,23 @@
+// swift-tools-version:5.5
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+
+import PackageDescription
+
+let package = Package(
Review Comment:
OK.
> Once this PR has been merged, I will look at registering this package in https://swiftpackageregistry.com/.
Don't do it yet. We must "release" only packages approved by PMC. We'll release this in the next 12.0.0.
See also: https://www.apache.org/legal/release-policy.html
##########
docker-compose.yml:
##########
@@ -869,6 +870,25 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-swift
+ build:
+ context: .
+ dockerfile: ci/docker/linux-apt-swift.dockerfile
Review Comment:
```suggestion
dockerfile: ci/docker/ubuntu-${UBUNTU}-swift.dockerfile
```
##########
ci/docker/linux-apt-swift.dockerfile:
##########
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+FROM swift:5.7.3
+
+RUN apt-get update -y -q && \
+ apt-get install -y -q \
+ binutils \
+ git \
+ gnupg2 \
+ libc6-dev \
+ libcurl4 \
+ libedit2 \
+ libgcc-9-dev \
+ libpython2.7 \
+ libsqlite3-0 \
+ libstdc++-9-dev \
+ libxml2 \
+ libz3-dev \
+ pkg-config \
+ tzdata \
+ zlib1g-dev \
+ wget && \
+ apt-get clean && \
+ ubuntu_version=$(. /etc/os-release && echo ${VERSION_ID}) && \
+ ubuntu_version_no_dot=$(echo ${ubuntu_version} | sed -e 's/\.//g') && \
+ wget https://download.swift.org/swift-5.7.3-release/ubuntu${ubuntu_version_no_dot}/swift-5.7.3-RELEASE/swift-5.7.3-RELEASE-ubuntu${ubuntu_version}.tar.gz && \
+ tar -xvzf swift-5.7.3-RELEASE-ubuntu${ubuntu_version}.tar.gz && \
+ rm swift-5.7.3-RELEASE-ubuntu${ubuntu_version}.tar.gz && \
+ mv swift-5.7.3-RELEASE-ubuntu${ubuntu_version} /swift
Review Comment:
Do we need this with `swift:5.7.3` image?
I think that `swift:5.7.3` image already includes Swift.
##########
.dockerignore:
##########
@@ -61,5 +61,4 @@
!rust/datafusion/Cargo.toml
!rust/datafusion/benches
!rust/integration-testing/Cargo.toml
-!go/go.mod
-!go/go.sum
\ No newline at end of file
+!go/go.mod
Review Comment:
Could you revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1086546420
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ ubuntu:
+ - 20.04
+ env:
+ UBUNTU: ${{ matrix.ubuntu }}
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Cache Docker Volumes
+ uses: actions/cache@v3
+ with:
+ path: .docker
+ key: ${{ matrix.cache }}-${{ hashFiles('swift/**') }}
+ restore-keys: ${{ matrix.cache }}-
+ - name: Setup Archery
+ run: pip install -e dev/archery[docker]
+ - name: Execute Docker Build
+ env:
+ ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
+ ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
+ run: |
+ sudo sysctl -w kernel.core_pattern="core.%e.%p"
+ ulimit -c unlimited
+ archery docker run ${{ matrix.image }}
+ - name: Docker Push
+ if: success() && github.event_name == 'push' && github.repository == 'apache/arrow'
+ env:
+ ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
+ ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
+ continue-on-error: true
+ run: archery docker push ${{ matrix.image }}
Review Comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1084315291
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ env:
+ UBUNTU: ${{ matrix.ubuntu || 20.04 }}
Review Comment:
Will remove matrix.ubuntu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1084984529
##########
swift/Arrow/Package.swift:
##########
@@ -0,0 +1,23 @@
+// swift-tools-version:5.5
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+
+import PackageDescription
+
+let package = Package(
Review Comment:
Most package formats can include license information.
Examples:
* Python package: https://pypi.org/project/pyarrow/ " License OSI Approved :: Apache Software License"
* Ruby package: https://rubygems.org/gems/red-arrow "License: Apache-2.0"
I'm sorry but I'm not familiar with Swift package format. If Swift package format supports license information, we should use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #14561:
URL: https://github.com/apache/arrow/pull/14561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1084658227
##########
.dockerignore:
##########
@@ -62,4 +62,5 @@
!rust/datafusion/benches
!rust/integration-testing/Cargo.toml
!go/go.mod
-!go/go.sum
\ No newline at end of file
+!go/go.sum
+!swift/Arrow
Review Comment:
I tried removing the above but it fails with the below error when I run 'archery docker run ubuntu-swift bash'
> [2/3] ADD swift/ /arrow/swift:
------
failed to compute cache key: "/swift" not found: not found
ERROR: Service ubuntu-swift failed to build : Build failed
Error: docker-compose --file /Users/alvabandy/Documents/GitHub/arrow/docker-compose.yml build --build-arg BUILDKIT_INLINE_CACHE=1 ubuntu-swift exited with a non-zero exit code 1, see the process log above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1087368442
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,79 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: AMD 64 Ubuntu 20.04 Swift 5.7
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 15
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Cache Docker Volumes
+ uses: actions/cache@v3
+ with:
+ path: .docker
+ key: ubuntu-20.04-swift-${{ hashFiles('swift/**') }}
+ restore-keys: ubuntu-20.04-swift-
Review Comment:
It shouldn't, I will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1084317711
##########
swift/Arrow/README.md:
##########
@@ -0,0 +1,49 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Apache Arrow
Review Comment:
Will do
##########
swift/Arrow/README.md:
##########
@@ -0,0 +1,49 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Apache Arrow
+
+An implementation of Arrow targeting Swift.
+
+# Status
Review Comment:
Will change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1086202991
##########
docker-compose.yml:
##########
@@ -141,6 +141,7 @@ x-hierarchy:
- ubuntu-python-sdist-test
- ubuntu-r
- ubuntu-r-only-r
+ - ubuntu-swift
Review Comment:
```suggestion
- ubuntu-swift
```
(We need to put this between `ubuntu-r-valgrind` and `ubuntu-verify-rc` to keep order.)
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ ubuntu:
+ - 20.04
+ env:
+ UBUNTU: ${{ matrix.ubuntu }}
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Cache Docker Volumes
+ uses: actions/cache@v3
+ with:
+ path: .docker
+ key: ${{ matrix.cache }}-${{ hashFiles('swift/**') }}
+ restore-keys: ${{ matrix.cache }}-
+ - name: Setup Archery
+ run: pip install -e dev/archery[docker]
+ - name: Execute Docker Build
+ env:
+ ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
+ ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
+ run: |
+ sudo sysctl -w kernel.core_pattern="core.%e.%p"
+ ulimit -c unlimited
+ archery docker run ${{ matrix.image }}
Review Comment:
```suggestion
archery docker run ubuntu-swift
```
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ ubuntu:
+ - 20.04
+ env:
+ UBUNTU: ${{ matrix.ubuntu }}
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Cache Docker Volumes
+ uses: actions/cache@v3
+ with:
+ path: .docker
+ key: ${{ matrix.cache }}-${{ hashFiles('swift/**') }}
+ restore-keys: ${{ matrix.cache }}-
+ - name: Setup Archery
+ run: pip install -e dev/archery[docker]
+ - name: Execute Docker Build
+ env:
+ ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
+ ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
+ run: |
+ sudo sysctl -w kernel.core_pattern="core.%e.%p"
+ ulimit -c unlimited
+ archery docker run ${{ matrix.image }}
+ - name: Docker Push
+ if: success() && github.event_name == 'push' && github.repository == 'apache/arrow'
+ env:
+ ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
+ ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
+ continue-on-error: true
+ run: archery docker push ${{ matrix.image }}
Review Comment:
```suggestion
run: archery docker push ubuntu-swift
```
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ ubuntu:
+ - 20.04
+ env:
+ UBUNTU: ${{ matrix.ubuntu }}
Review Comment:
```suggestion
name: AMD 64 Ubuntu 20.04 Swift 5.7
runs-on: ubuntu-latest
if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
timeout-minutes: 15
```
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ ubuntu:
+ - 20.04
+ env:
+ UBUNTU: ${{ matrix.ubuntu }}
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Cache Docker Volumes
+ uses: actions/cache@v3
+ with:
+ path: .docker
+ key: ${{ matrix.cache }}-${{ hashFiles('swift/**') }}
+ restore-keys: ${{ matrix.cache }}-
Review Comment:
```suggestion
key: ubuntu-20.04-swift-${{ hashFiles('swift/**') }}
restore-keys: ubuntu-20.04-swift-
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1095412981
##########
ci/docker/ubuntu-swift.dockerfile:
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+FROM swift:5.7.3
+
+RUN apt-get update -y -q && \
+ apt-get clean
Review Comment:
I've pushed a change to remove this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1414527230
Sorry. One my comment wasn't submitted. Could you confirm it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1093828566
##########
docker-compose.yml:
##########
@@ -869,6 +870,23 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-swift
+ build:
+ context: .
+ dockerfile: ci/docker/ubuntu-${UBUNTU}-swift.dockerfile
Review Comment:
Will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1415951688
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/049577a57185497f90aa300c29468620...eeb47248d3d94f06b2dcb1d990c721ac/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by GitBox <gi...@apache.org>.
abandy commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1387048498
Awesome, will do, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1084314078
##########
docker-compose.yml:
##########
@@ -1400,7 +1423,8 @@ services:
ARROW_R_DEV: "true"
volumes: *ubuntu-volumes
command: >
- /bin/bash -c "/arrow/ci/scripts/r_revdepcheck.sh /arrow"
+ /bin/bash -c "
+ /arrow/ci/scripts/r_revdepcheck.sh /arrow"
Review Comment:
Yeah, that is strange formatting, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14561: ARROW-18234: [Archery] Initial swift arrow impl
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1301484894
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14561: ARROW-18234: [Archery] Initial swift arrow impl
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1301484878
https://issues.apache.org/jira/browse/ARROW-18234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1378207697
There are Apache Arrow files in https://github.com/apache/arrow-testing but most files are not for implementation testing...
We have a integration test framework: https://github.com/apache/arrow/tree/master/dev/archery/archery/integration
It compares outputs between other language implementations. Finally, this Swift implementation should join it but it may not be suitable for the first step...
> I have been working on the swift arrow IPC impl to add to this PR. Are there any test files in the arrow repo that I can use to test an IPC reader/writer?
How about split the implementation to another pull request? I don't want to review a large pull request as much as possible...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1086577877
##########
docker-compose.yml:
##########
@@ -869,6 +870,25 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-swift
+ build:
+ context: .
+ dockerfile: ci/docker/ubuntu-${UBUNTU}-swift.dockerfile
+ shm_size: *shm-size
+ environment:
+ <<: *ccache
+ volumes: *ubuntu-volumes
+ command: >
+ /bin/bash -c "/arrow/ci/scripts/swift_test.sh /arrow"
Review Comment:
Good point, "swift test" will start the build. I will remove the swift_build.sh script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1092809344
##########
docker-compose.yml:
##########
@@ -869,6 +870,23 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-swift
+ build:
+ context: .
+ dockerfile: ci/docker/ubuntu-${UBUNTU}-swift.dockerfile
Review Comment:
```suggestion
dockerfile: ci/docker/ubuntu-swift.dockerfile
```
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,72 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/*swift*'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/*swift*'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+ docker:
+ name: AMD 64 Ubuntu 20.04 Swift 5.7
Review Comment:
`swift:5.7.3` isn't based on Ubuntu 20.04 (it's based on Ubuntu 22.04):
```suggestion
name: AMD 64 Ubuntu Swift 5.7
```
##########
docker-compose.yml:
##########
@@ -869,6 +870,23 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-swift
Review Comment:
```suggestion
image: ${REPO}:${ARCH}-ubuntu-swift
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1095207619
##########
docker-compose.yml:
##########
@@ -870,6 +871,23 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
Review Comment:
No worries, good catch! Will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1084320477
##########
swift/Arrow/Package.swift:
##########
@@ -0,0 +1,23 @@
+// swift-tools-version:5.5
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+
+import PackageDescription
+
+let package = Package(
Review Comment:
I am not sure what you mean. I didn't see an attribute on Package for a license.
##########
swift/Arrow/Package.swift:
##########
@@ -0,0 +1,23 @@
+// swift-tools-version:5.5
+// The swift-tools-version declares the minimum version of Swift required to build this package.
Review Comment:
Will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1084448849
##########
docker-compose.yml:
##########
@@ -869,6 +870,28 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-cpp
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-swift
+ build:
+ context: .
+ dockerfile: ci/docker/linux-apt-swift.dockerfile
+ args:
+ base: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-cpp
Review Comment:
Good idea, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1086557338
##########
docker-compose.yml:
##########
@@ -869,6 +870,25 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-swift
+ build:
+ context: .
+ dockerfile: ci/docker/ubuntu-${UBUNTU}-swift.dockerfile
+ shm_size: *shm-size
+ environment:
+ <<: *ccache
+ volumes: *ubuntu-volumes
+ command: >
+ /bin/bash -c "/arrow/ci/scripts/swift_test.sh /arrow"
Review Comment:
I have no experience with swift but don't we have to build first? I can't see us using the added `swift_build.sh` script anywhere, is it necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1087189458
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,79 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
Review Comment:
this seems a bit broad to me, in the interest of being conservative with our usage of the common apache runners I think being more specific here would be good
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,79 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
Review Comment:
```suggestion
```
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,79 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: AMD 64 Ubuntu 20.04 Swift 5.7
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 15
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Cache Docker Volumes
+ uses: actions/cache@v3
+ with:
+ path: .docker
+ key: ubuntu-20.04-swift-${{ hashFiles('swift/**') }}
+ restore-keys: ubuntu-20.04-swift-
Review Comment:
Is this actually needed? Does swift cache anything in one of the applicable volumes like the c++ builds do with ccache?
##########
docker-compose.yml:
##########
@@ -869,6 +870,25 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-swift
+ build:
+ context: .
+ dockerfile: ci/docker/ubuntu-${UBUNTU}-swift.dockerfile
+ shm_size: *shm-size
+ environment:
+ <<: *ccache
Review Comment:
Is this needed?
##########
swift/Arrow/Package.swift:
##########
@@ -0,0 +1,23 @@
+// swift-tools-version:5.5
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+
+import PackageDescription
+
+let package = Package(
Review Comment:
@abandy I am not familar with swift how is it distributed? Are the binary artifacts that need to be built and distributed or is it more in line with go where a github tag is the only thing required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by GitBox <gi...@apache.org>.
abandy commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1307949800
Great idea, will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1084315291
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ env:
+ UBUNTU: ${{ matrix.ubuntu || 20.04 }}
Review Comment:
Compared the other yml workflow files and noticed that matrix.ubuntu is defined under a strategy node. I will add that value under strategy and hopefully that will be picked up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1084443652
##########
ci/docker/linux-apt-swift.dockerfile:
##########
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ARG base
+FROM ${base}
+
+ADD swift/ /arrow/swift
+RUN apt-get update -y -q && \
+ apt-get install -y -q \
+ binutils \
+ git \
+ gnupg2 \
+ libc6-dev \
+ libcurl4 \
+ libedit2 \
+ libgcc-9-dev \
+ libpython2.7 \
+ libsqlite3-0 \
+ libstdc++-9-dev \
+ libxml2 \
+ libz3-dev \
+ pkg-config \
+ tzdata \
+ zlib1g-dev \
+ wget && \
+ apt-get clean && \
+ wget https://download.swift.org/swift-5.7.1-release/ubuntu2004/swift-5.7.1-RELEASE/swift-5.7.1-RELEASE-ubuntu20.04.tar.gz
+
+RUN tar -xvzf swift-5.7.1-RELEASE-ubuntu20.04.tar.gz
+ENV PATH=/swift-5.7.1-RELEASE-ubuntu20.04/usr/bin:$PATH
Review Comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1084658227
##########
.dockerignore:
##########
@@ -62,4 +62,5 @@
!rust/datafusion/benches
!rust/integration-testing/Cargo.toml
!go/go.mod
-!go/go.sum
\ No newline at end of file
+!go/go.sum
+!swift/Arrow
Review Comment:
I tried removing the above but it fails with the below error when I run 'archery docker run ubuntu-swift bash'
` > [2/3] ADD swift/ /arrow/swift:
------
failed to compute cache key: "/swift" not found: not found
ERROR: Service ubuntu-swift failed to build : Build failed
Error: docker-compose --file /Users/alvabandy/Documents/GitHub/arrow/docker-compose.yml build --build-arg BUILDKIT_INLINE_CACHE=1 ubuntu-swift exited with a non-zero exit code 1, see the process log above.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: ARROW-18234: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1084314078
##########
docker-compose.yml:
##########
@@ -1400,7 +1423,8 @@ services:
ARROW_R_DEV: "true"
volumes: *ubuntu-volumes
command: >
- /bin/bash -c "/arrow/ci/scripts/r_revdepcheck.sh /arrow"
+ /bin/bash -c "
+ /arrow/ci/scripts/r_revdepcheck.sh /arrow"
Review Comment:
Yes, that is strange formatting, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1093828420
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,72 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/*swift*'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/*swift*'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+ docker:
+ name: AMD 64 Ubuntu 20.04 Swift 5.7
Review Comment:
Will do.
##########
docker-compose.yml:
##########
@@ -869,6 +870,23 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-swift
Review Comment:
Will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #14561:
URL: https://github.com/apache/arrow/pull/14561#issuecomment-1415951265
Benchmark runs are scheduled for baseline = 2ad89525173bbe3e03814eb4310b6e58fad5b989 and contender = c9b6559d8a3f797c2606be1ee6490b46cb17e9e3. c9b6559d8a3f797c2606be1ee6490b46cb17e9e3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/549e1c74e1c246e99352995d1a64db43...75b89092523e45ed935eb6ad6c07c52e/)
[Failed :arrow_down:0.52% :arrow_up:0.15%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d45d558782974d3ba717a6d47144fdac...7b373035d56a4c6a87214193b57ec6d4/)
[Finished :arrow_down:1.79% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/049577a57185497f90aa300c29468620...eeb47248d3d94f06b2dcb1d990c721ac/)
[Finished :arrow_down:0.32% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3595aa5a7699444d81957c3225d67820...5d6765c2105949748ac0077d9419f307/)
Buildkite builds:
[Finished] [`c9b6559d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2316)
[Failed] [`c9b6559d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2343)
[Finished] [`c9b6559d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2314)
[Finished] [`c9b6559d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2334)
[Finished] [`2ad89525` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2315)
[Finished] [`2ad89525` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2342)
[Finished] [`2ad89525` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2313)
[Finished] [`2ad89525` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2333)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1087368065
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,79 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
Review Comment:
Will change to - 'ci/docker/*swift*'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1095213570
##########
ci/docker/ubuntu-swift.dockerfile:
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+FROM swift:5.7.3
+
+RUN apt-get update -y -q && \
+ apt-get clean
Review Comment:
I think that this `RUN` does nothing.
Can we remove this? Furthermore, can we use `swift:5.7.3` directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org