[GitHub] [pulsar] codelipenghui commented on a change in pull request #9517: Add listeningInterface in broker.conf,Use Network Interface instead of IP

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #9517:
URL: https://github.com/apache/pulsar/pull/9517#discussion_r572056157



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -1224,7 +1226,23 @@ public ShutdownService getShutdownService() {
      * @return Hostname or IP address the service advertises to the outside world.
      */
     public static String advertisedAddress(ServiceConfiguration config) {
-        return ServiceConfigurationUtils.getDefaultOrConfiguredAddress(config.getAdvertisedAddress());

Review comment:
       Could you please update the `ServiceConfigurationUtils.getDefaultOrConfiguredAddress` to support get default IP of the listening interface if the advertisedAddress absent but the listening interface present?
   
   And shall we need to avoid users to configure the both listeningInterface and `bindAddress`? Seems setting both at the same time will cause some confusion.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org