You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/09/14 11:30:12 UTC

[GitHub] [lucene] romseygeek commented on pull request #299: LUCENE-8638: Expressions haversin() method should continue to return its value in km

romseygeek commented on pull request #299:
URL: https://github.com/apache/lucene/pull/299#issuecomment-919063319


   Somewhat annoyingly we can't make the new ExpressionMath class package-private as the javascript engine needs all methods to be publicly discoverable.  There also isn't an easy way to indicate deprecations from within expressions; I think this is probably the best compromise available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org