[jira] [Work logged] (BEAM-11091) HadoopFormatIO should allow to specify coders

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-11091?focusedWorklogId=507254&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-507254 ]

ASF GitHub Bot logged work on BEAM-11091:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Nov/20 17:39
            Start Date: 03/Nov/20 17:39
    Worklog Time Spent: 10m 
      Work Description: aromanenko-dev commented on a change in pull request #13166:
URL: https://github.com/apache/beam/pull/13166#discussion_r516840231



##########
File path: sdks/java/io/hadoop-format/src/test/java/org/apache/beam/sdk/io/hadoop/format/HadoopFormatIOReadTest.java
##########
@@ -229,6 +284,14 @@ public void testReadObjectCreationFailsIfValueTranslationFunctionIsNull() {
     HadoopFormatIO.<Text, String>read().withConfiguration(serConf.get()).withValueTranslation(null);
   }
 
+  @Test
+  public void testReadObjectCreationFailsIfValueCoderFunctionIsNull() {

Review comment:
       nit: I guess the word `Function` is redundant here (like you called a similar key test `testReadObjectCreationFailsIfKeyCoderIsNull `)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 507254)
    Time Spent: 1.5h  (was: 1h 20m)

> HadoopFormatIO should allow to specify coders
> ---------------------------------------------
>
>                 Key: BEAM-11091
>                 URL: https://issues.apache.org/jira/browse/BEAM-11091
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-hadoop-format
>    Affects Versions: 2.24.0
>            Reporter: Jozef Vilcek
>            Assignee: Jozef Vilcek
>            Priority: P3
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> HadoopFormatIO does allow only to pass in type descriptors for key and value and those are then resolved to Coder via CoderRegistry.
> We did find this restrictive after https://issues.apache.org/jira/browse/BEAM-9569
> which makes it impossible to emit Row out of the source.
> Easy solution I see can be to allow set Coder directly and bypass the resolution against registry in that case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)