[jira] [Resolved] (CALCITE-1381) Function quantifier should be retained in a cloned Sql call

["Julian Hyde (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde resolved CALCITE-1381.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.10.0

Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/8d9a5d24. Thanks for the patch, [~zhengd]!

> Function quantifier should be retained in a cloned Sql call 
> ------------------------------------------------------------
>
>                 Key: CALCITE-1381
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1381
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.8.0, 1.6.0
>            Reporter: zhengdong
>            Assignee: Julian Hyde
>            Priority: Minor
>             Fix For: 1.10.0
>
>         Attachments: 0001-Override-clone-method-in-SqlBasicCall-to-fix-Nullif-function.patch, CALCITE-1381-Function-quantifier-should-be-retained-.patch, CALCITE-1381-Function-quantifier-should-be-retained-.patch
>
>
> I found Calcite can’t execute queries like {{select nullif(count(distinct colunm),0) from table}}, and dumped ‘Plan after trimming unused fields’ like this:
> {noformat}
> LogicalProject(NAME=[$0], GENDER=[CASE(=($1, 0), null, CAST($2):BIGINT)])
>   LogicalAggregate(group=[{0}], agg#0=[COUNT(DISTINCT $1)], agg#1=[COUNT($1)])
>     LogicalProject(NAME=[$1], GENDER=[$3])
>       CsvTableScan(table=[[SALES, EMPS]], fields=[[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]])
> {noformat}
> Then, I checked SqlNullifFunction rewriteCall method which used SqlNode.clone(SqlParserPos pos) method to create SqlCase call.
> Finally, I guess the root cause may be that the clone(SqlParserPos pos) method discard the functionQuantifier which holds such as ‘distinct’ symbol when create new SqlCall instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)