You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/07/22 05:42:44 UTC
[GitHub] [helix] qqu0127 opened a new issue, #2178: Thread leakage from BestPossibleExternalViewVerifier.verify()
qqu0127 opened a new issue, #2178:
URL: https://github.com/apache/helix/issues/2178
### Describe the bug
We detected a resource leakage from BestPossibleExternalViewVerifier.verify(), there is a loop where ZkClient could be continuously created but never closed. This may drain JVM thread and ZK connection and severely damage system stability.
The code path for zkclient creation:
`ZkHelixClusterVerifier.handleDataChange() -> verifyState() submit to verifier threadpool -> BestPossibleExternalViewVerifier.calcBestPossState() -> DryrunWagedRebalancer -> ZkBucketDataAccessor -> createRealmAwareZkClient`
Notice that `ReadOnlyAssignmentMetadataStore` override `close()` with a dummy method, as a result zkclient in `ZkBucketDataAccessor` is never closed.
Impact: all participants or controllers that are using BestPossibleExternalViewVerifier.verify() or verifyByCallback() may have thread leak and large number of ZK connections.
### Expected behavior
ZkClient and other resources should be properly closed.
### Additional context
Suspect breaking change: https://github.com/apache/helix/pull/1747
Impact version: 1.0.3+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue closed issue #2178: Thread leakage from BestPossibleExternalViewVerifier.verify()
Posted by GitBox <gi...@apache.org>.
junkaixue closed issue #2178: Thread leakage from BestPossibleExternalViewVerifier.verify()
URL: https://github.com/apache/helix/issues/2178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org