[jira] [Commented] (BEAM-395) KafkaIO tests should be marked 'NeedsRunner'

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357575#comment-15357575 ] 

ASF GitHub Bot commented on BEAM-395:
-------------------------------------

GitHub user rangadi opened a pull request:

    https://github.com/apache/incubator-beam/pull/568

    [BEAM-395] KafkaIO tests should be marked 'NeedsRunner'

    
    KafkaIO Tests are currently marked as 'RunnableOnService', which implies the tests can run on any beam runner. This is not correct. 
    
    Though the tests are not runner dependent per se, they depend on mocks for Kafka consumer and kafka producer. That requires the tests to be local to a JVM. These tests can only run on single JVM runners like DirectRunner.
    
    These tests should be marked 'NeedsRunner' for now.
    -----------
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rangadi/incubator-beam test-annotations

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/568.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #568
    
----

----


> KafkaIO tests should be marked 'NeedsRunner'
> --------------------------------------------
>
>                 Key: BEAM-395
>                 URL: https://issues.apache.org/jira/browse/BEAM-395
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions, testing
>    Affects Versions: 0.1.0-incubating
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>
> KafkaIO Tests are currently marked as 'RunnableOnService', which implies the tests can run on any beam runner. This is not correct. 
> Though the tests are not runner dependent per se, they depend on mocks for Kafka consumer and kafka producer. That requires the tests to be local to a JVM. These tests can only run on single JVM runners like DirectRunner.
> These tests should be marked 'NeedsRunner' for now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)