You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2013/08/03 22:52:00 UTC
[51/52] [abbrv] git commit: TS-2081 Make the WCCP addr configuration
LOCAL
TS-2081 Make the WCCP addr configuration LOCAL
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/994d978a
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/994d978a
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/994d978a
Branch: refs/heads/3.3.x
Commit: 994d978a060012de934b80857d1dfab817f18a3a
Parents: 76ef33d
Author: Leif Hedstrom <zw...@apache.org>
Authored: Sat Aug 3 22:40:10 2013 +0200
Committer: Leif Hedstrom <zw...@apache.org>
Committed: Sat Aug 3 22:40:10 2013 +0200
----------------------------------------------------------------------
CHANGES | 2 ++
mgmt/RecordsConfig.cc | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/994d978a/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index 292e846..fd7218c 100644
--- a/CHANGES
+++ b/CHANGES
@@ -2,6 +2,8 @@
Changes with Apache Traffic Server 3.3.5
+ *) [TS-2081] Make the WCCP addr configuration LOCAL.
+
*) [TS-2093] Check bounds on plugin stat creation.
*) [TS-2092] Use of uninitialized member in HdrHeap.
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/994d978a/mgmt/RecordsConfig.cc
----------------------------------------------------------------------
diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
index 0cf67a8..bf4b9ee 100644
--- a/mgmt/RecordsConfig.cc
+++ b/mgmt/RecordsConfig.cc
@@ -1305,7 +1305,7 @@ RecordElement RecordsConfig[] = {
//# WCCP
//#
//############################################################################
- {RECT_CONFIG, "proxy.config.wccp.addr", RECD_STRING, "", RECU_RESTART_TM, RR_NULL, RECC_STR, NULL, RECA_NULL}
+ {RECT_LOCAL, "proxy.config.wccp.addr", RECD_STRING, "", RECU_RESTART_TM, RR_NULL, RECC_STR, NULL, RECA_NULL}
,
{RECT_CONFIG, "proxy.config.wccp.services", RECD_STRING, "", RECU_RESTART_TM, RR_NULL, RECC_STR, NULL, RECA_NULL }
,
Re: [51/52] [abbrv] git commit: TS-2081 Make the WCCP addr
configuration LOCAL
Posted by Igor Galić <i....@brainsware.org>.
----- Original Message -----
> On Aug 5, 2013, at 10:45 AM, Igor Galić <i....@brainsware.org> wrote:
>
> >
> >> RR_NULL, RECC_STR, NULL, RECA_NULL}
> >> + {RECT_LOCAL, "proxy.config.wccp.addr", RECD_STRING, "",
> >> RECU_RESTART_TM,
> >> RR_NULL, RECC_STR, NULL, RECA_NULL}
> >> ,
> >
> > shouldn't it then be proxy.local.wccp.addr ?
>
>
> Perhaps, but don't think there's a "rule" on that. I opted to not break
> compatibility (i.e. this change doesn't break any existing records.config
> using the option afaik).
>
> Up to amc to decide if he wants to rename the config.
I'm a big fan of consistency, and given that this option isn't even
documented, I'm not sure exactly what we're breaking ;)
> -- leif
>
>
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
Re: [51/52] [abbrv] git commit: TS-2081 Make the WCCP addr configuration LOCAL
Posted by Leif Hedstrom <le...@ogre.com>.
On Aug 5, 2013, at 10:45 AM, Igor Galić <i....@brainsware.org> wrote:
>
>> RR_NULL, RECC_STR, NULL, RECA_NULL}
>> + {RECT_LOCAL, "proxy.config.wccp.addr", RECD_STRING, "", RECU_RESTART_TM,
>> RR_NULL, RECC_STR, NULL, RECA_NULL}
>> ,
>
> shouldn't it then be proxy.local.wccp.addr ?
Perhaps, but don't think there's a "rule" on that. I opted to not break compatibility (i.e. this change doesn't break any existing records.config using the option afaik).
Up to amc to decide if he wants to rename the config.
-- leif
Re: [51/52] [abbrv] git commit: TS-2081 Make the WCCP addr
configuration LOCAL
Posted by Igor Galić <i....@brainsware.org>.
----- Original Message -----
> TS-2081 Make the WCCP addr configuration LOCAL
>
>
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/994d978a
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/994d978a
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/994d978a
>
> Branch: refs/heads/3.3.x
> Commit: 994d978a060012de934b80857d1dfab817f18a3a
> Parents: 76ef33d
> Author: Leif Hedstrom <zw...@apache.org>
> Authored: Sat Aug 3 22:40:10 2013 +0200
> Committer: Leif Hedstrom <zw...@apache.org>
> Committed: Sat Aug 3 22:40:10 2013 +0200
>
> ----------------------------------------------------------------------
> CHANGES | 2 ++
> mgmt/RecordsConfig.cc | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/994d978a/CHANGES
> ----------------------------------------------------------------------
> diff --git a/CHANGES b/CHANGES
> index 292e846..fd7218c 100644
> --- a/CHANGES
> +++ b/CHANGES
> @@ -2,6 +2,8 @@
> Changes with Apache Traffic Server 3.3.5
>
>
> + *) [TS-2081] Make the WCCP addr configuration LOCAL.
> +
> *) [TS-2093] Check bounds on plugin stat creation.
>
> *) [TS-2092] Use of uninitialized member in HdrHeap.
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/994d978a/mgmt/RecordsConfig.cc
> ----------------------------------------------------------------------
> diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
> index 0cf67a8..bf4b9ee 100644
> --- a/mgmt/RecordsConfig.cc
> +++ b/mgmt/RecordsConfig.cc
> @@ -1305,7 +1305,7 @@ RecordElement RecordsConfig[] = {
> //# WCCP
> //#
> //############################################################################
> - {RECT_CONFIG, "proxy.config.wccp.addr", RECD_STRING, "", RECU_RESTART_TM,
> RR_NULL, RECC_STR, NULL, RECA_NULL}
> + {RECT_LOCAL, "proxy.config.wccp.addr", RECD_STRING, "", RECU_RESTART_TM,
> RR_NULL, RECC_STR, NULL, RECA_NULL}
> ,
shouldn't it then be proxy.local.wccp.addr ?
> {RECT_CONFIG, "proxy.config.wccp.services", RECD_STRING, "",
> RECU_RESTART_TM, RR_NULL, RECC_STR, NULL, RECA_NULL }
> ,
>
>
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE