You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2026/04/24 17:59:48 UTC
[PR] fix(sqllab): explore to chart is disabled [superset]
justinpark opened a new pull request, #39630:
URL: https://github.com/apache/superset/pull/39630
### SUMMARY
bootstrap_sqllab_data built the per-database dict by filtering database.to_json() against DATABASE_KEYS, but some keys in DATABASE_KEYS (e.g. backend, allow_multi_catalog) are not serialized by to_json(), so they were silently dropped and then patched back with manual assignments.
This change iterates over DATABASE_KEYS directly and uses to_json() as the primary source, falling back to getattr(database, k) for any key not present in the JSON output. The separate redundant assignments for backend and allow_multi_catalog are removed.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="555" height="368" alt="Screenshot 2026-04-24 at 10 44 58 AM" src="https://github.com/user-attachments/assets/429026f6-20c7-414f-9c84-5cd8de6cee58" />
After:
<img width="580" height="414" alt="Screenshot 2026-04-24 at 10 45 35 AM" src="https://github.com/user-attachments/assets/e5cce526-c4e8-4a4b-8163-9cac20833385" />
|Before|After|
|--|--|
|<img width="640" height="417" alt="superset-test-1_a_musta_ch_api_v1_sqllab_" src="https://github.com/user-attachments/assets/72d5bf97-4d60-41e5-bb53-089e26ae69a1" />|<img width="577" height="482" alt="localhost_8088_api_v1_sqllab_" src="https://github.com/user-attachments/assets/6c4b3113-1f6b-4252-b37f-ffd74766b2e3" />|
### TESTING INSTRUCTIONS
1. Enable subquery in a database option
2. Go to SQL Lab and then run a query
3. "Create Chart" should be enabled
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sqllab): explore to chart is disabled [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #39630:
URL: https://github.com/apache/superset/pull/39630#issuecomment-4315287310
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/39630?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.30%. Comparing base ([`8ce2343`](https://app.codecov.io/gh/apache/superset/commit/8ce234371b9c32d50a85eccaba4d46db9505e6e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8913a57`](https://app.codecov.io/gh/apache/superset/commit/8913a57b8e806b9669e86fa66f8e99dbb608ee57?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 113 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/39630?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/sqllab/utils.py](https://app.codecov.io/gh/apache/superset/pull/39630?src=pr&el=tree&filepath=superset%2Fsqllab%2Futils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc3FsbGFiL3V0aWxzLnB5) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/39630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8ce2343) and HEAD (8913a57). Click for more details.
>
> <details><summary>HEAD has 63 uploads less than BASE</summary>
>
>| Flag | BASE (8ce2343) | HEAD (8913a57) |
>|------|------|------|
>|python|59|1|
>|presto|6|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #39630 +/- ##
==========================================
- Coverage 64.51% 55.30% -9.22%
==========================================
Files 2557 2563 +6
Lines 133049 133580 +531
Branches 30901 30990 +89
==========================================
- Hits 85843 73878 -11965
- Misses 45716 59048 +13332
+ Partials 1490 654 -836
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/39630/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/39630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/39630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/39630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/39630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.56% <0.00%> (-0.13%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/39630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.56% <0.00%> (-20.64%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/39630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/39630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/39630?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sqllab): explore to chart is disabled [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #39630:
URL: https://github.com/apache/superset/pull/39630#issuecomment-4315289635
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 8913a57b8e806b9669e86fa66f8e99dbb608ee57 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69ebaf95cab7ea0008cbc5d2 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-39630--superset-docs-preview.netlify.app](https://deploy-preview-39630--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-39630--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sqllab): explore to chart is disabled [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #39630:
URL: https://github.com/apache/superset/pull/39630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sqllab): explore to chart is disabled [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39630:
URL: https://github.com/apache/superset/pull/39630#issuecomment-4315259521
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org