You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tiles.apache.org by Nicolas LE BAS <ma...@nlebas.net> on 2012/04/30 14:51:57 UTC
Re: svn commit: r1332134 - in /tiles/framework/trunk: tiles-parent/tiles-core/src/main/java/org/apache/tiles/startup/
tiles-parent/tiles-core/src/test/java/org/apache/tiles/startup/ tiles-parent/tiles-jsp/src/test/java/org/apache/tiles/jsp/taglib/
tiles-re...
I think this is a slight mistake: SCOPES contains only {"page"}, it
should contain {"page", parent.availableScopes}.
Same for Velocity (JSP is correct however).
And the unit test is missing.
On 12-04-30 05:23 AM, mck@apache.org wrote:
> Modified: tiles/framework/trunk/tiles-request/tiles-request-freemarker/src/main/java/org/apache/tiles/request/freemarker/FreemarkerRequest.java
> URL:http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-request/tiles-request-freemarker/src/main/java/org/apache/tiles/request/freemarker/FreemarkerRequest.java?rev=1332134&r1=1332133&r2=1332134&view=diff
> ==============================================================================
> --- tiles/framework/trunk/tiles-request/tiles-request-freemarker/src/main/java/org/apache/tiles/request/freemarker/FreemarkerRequest.java (original)
> +++ tiles/framework/trunk/tiles-request/tiles-request-freemarker/src/main/java/org/apache/tiles/request/freemarker/FreemarkerRequest.java Mon Apr 30 09:23:19 2012
> @@ -121,7 +121,7 @@ public class FreemarkerRequest extends A
> }
>
> @Override
> - public List<String> getNativeScopes() {
> + public List<String> getAvailableScopes() {
> return SCOPES;
> }
>
Re: svn commit: r1332134 - in /tiles/framework/trunk:
tiles-parent/tiles-core/src/main/java/org/apache/tiles/startup/
tiles-parent/tiles-core/src/test/java/org/apache/tiles/startup/
tiles-parent/tiles-jsp/src/test/java/org/apache/tiles/jsp/taglib/
tiles-re...
Posted by Mick Semb Wever <mc...@apache.org>.
On Mon, 2012-04-30 at 08:51 -0400, Nicolas LE BAS wrote:
> I think this is a slight mistake: SCOPES contains only {"page"}, it
> should contain {"page", parent.availableScopes}.
>
> Same for Velocity (JSP is correct however).
I completely missed that.
Did it ever work that way?
(has it been messed up recently?)
~mck
--
Daddy, why doesn't this magnet pick up this floppy disk?
| http://github.com/finn-no | http://tech.finn.no |