You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/28 05:51:27 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5365: Revert "sim: add CONFIG_SIM_STACKSIZE_ADJUSTMENT to reduce variability"
xiaoxiang781216 commented on a change in pull request #5365:
URL: https://github.com/apache/incubator-nuttx/pull/5365#discussion_r794219857
##########
File path: sched/Kconfig
##########
@@ -1828,12 +1828,14 @@ menu "Stack and heap information"
config DEFAULT_TASK_STACKSIZE
int "The default stack size for tasks"
+ default 65536 if ARCH_SIM
Review comment:
please don't add sim specific setting in common place.
##########
File path: sched/Kconfig
##########
@@ -1828,12 +1828,14 @@ menu "Stack and heap information"
config DEFAULT_TASK_STACKSIZE
int "The default stack size for tasks"
+ default 65536 if ARCH_SIM
default 2048
---help---
The default stack size for tasks.
config IDLETHREAD_STACKSIZE
int "Idle thread stack size"
+ default DEFAULT_TASK_STACKSIZE if ARCH_SIM
Review comment:
same, remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org