[GitHub] [solr] janhoy commented on a diff in pull request #1287: SOLR-16619: Fix `solr` script for IBM i

[GitBox <gi...@apache.org>]

janhoy commented on code in PR #1287:
URL: https://github.com/apache/solr/pull/1287#discussion_r1069521742


##########
solr/bin/solr:
##########
@@ -716,7 +716,11 @@ function solr_pid_by_port() {
 # extract the value of the -Djetty.port parameter from a running Solr process
 function jetty_port() {
   SOLR_PID="$1"
-  SOLR_PROC=$(ps -o command='' -p "$SOLR_PID" | grep start\.jar | grep jetty\.port)
+  if [ "OS400" == "$THIS_OS" ]; then
+    SOLR_PROC=`ps -f -p "$SOLR_PID" | grep start\.jar | grep jetty\.port`

Review Comment:
   Please stick to the `$(foo)` syntax



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org