[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #318: Synchronize write mode among writers

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #318: Synchronize write mode among writers
URL: https://github.com/apache/incubator-iceberg/pull/318#discussion_r307819407
 
 

 ##########
 File path: orc/src/main/java/org/apache/iceberg/orc/ORC.java
 ##########
 @@ -64,6 +65,12 @@ private WriteBuilder(OutputFile file) {
       }
     }
 
+    public WriteBuilder forTable(Table table) {
+      schema(table.schema());
+      setAll(table.properties());
 
 Review comment:
   I think this change is unrelated and should go in a separate PR. It's a good idea to add this, just not here.
   
   Also, I think this should do some translation from table properties to ORC properties, like taking `write.orc.compression-codec` and setting the correct property for ORC.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org