[GitHub] [nifi] dazhitchman commented on pull request #4385: NIFI-7600 - Defining JMS attribute types breaks due to invalid charac…

[GitBox <gi...@apache.org>]

dazhitchman commented on pull request #4385:
URL: https://github.com/apache/nifi/pull/4385#issuecomment-654467047


   Hi Joey
   
   I think that opens up others issues. NIFI uses attributes for both data (to augment content) and metadata to control behaviour.  In the JMS example, there is no valid JMS field for “JMS_IBM_Encoding.type” , it is just used to help the processor build the headers so it shouldn’t leak from the processor.  The mime type however is used by downstream applications like a web/email server so they should be passed along. I am new to NIFI though so happy to take advice.
   
   Darren
   
   > On 7 Jul 2020, at 5:23 am, Joey <no...@github.com> wrote:
   > 
   > 
   > @jfrazee commented on this pull request.
   > 
   > In nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/JMSPublisher.java <https://github.com/apache/nifi/pull/4385#discussion_r450432161>:
   > 
   > > @@ -108,6 +108,13 @@ void setMessageHeaderAndProperties(final Session session, final Message message,
   >                          }
   >                      } else {
   >                          // not a special attribute handled above, so send it as a property using the specified property type
   > +                        String key=entry.getKey();
   > +                        if (key.endsWith(".type")){
   > If we go broad and apply this to anything ending in '.type' I think it deserves a WARN.
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub <https://github.com/apache/nifi/pull/4385#pullrequestreview-443347444>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOLUPLLFJR7ULDX764J72EDR2IQC5ANCNFSM4ORGHSFQ>.
   > 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org