You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2010/05/03 23:04:55 UTC
[jira] Created: (LUCENE-2439) Composite readers
(Multi/DirIndexReader) should not subclass IndexReader
Composite readers (Multi/DirIndexReader) should not subclass IndexReader
------------------------------------------------------------------------
Key: LUCENE-2439
URL: https://issues.apache.org/jira/browse/LUCENE-2439
Project: Lucene - Java
Issue Type: Improvement
Components: Index
Reporter: Michael McCandless
Fix For: 4.0.0
I'd like to change Multi/DirIndexReader so that they no longer implement the low level methods of IndexReader, and instead act more like an ordered collection of sub readers. I think to do this we'd need a new interface, common to atomic readers (SegmentReader) and the composite readers, which IndexSearcher would accept.
We should also require that the core Query scorers always receive an atomic reader.
We've taken strong initial steps here with flex, by forcing users to use separate MultiFields static methods to obtain Fields/Terms/etc. from a composite reader. This issue is to finish this cutover.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2439) Composite readers
(Multi/DirIndexReader) should not subclass IndexReader
Posted by "Earwin Burrfoot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863744#action_12863744 ]
Earwin Burrfoot commented on LUCENE-2439:
-----------------------------------------
I got sidetracked for some time, but plan to finish on this weekend.
> Composite readers (Multi/DirIndexReader) should not subclass IndexReader
> ------------------------------------------------------------------------
>
> Key: LUCENE-2439
> URL: https://issues.apache.org/jira/browse/LUCENE-2439
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Fix For: 4.0.0
>
>
> I'd like to change Multi/DirIndexReader so that they no longer implement the low level methods of IndexReader, and instead act more like an ordered collection of sub readers. I think to do this we'd need a new interface, common to atomic readers (SegmentReader) and the composite readers, which IndexSearcher would accept.
> We should also require that the core Query scorers always receive an atomic reader.
> We've taken strong initial steps here with flex, by forcing users to use separate MultiFields static methods to obtain Fields/Terms/etc. from a composite reader. This issue is to finish this cutover.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2439) Composite readers
(Multi/DirIndexReader) should not subclass IndexReader
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863724#action_12863724 ]
Michael McCandless commented on LUCENE-2439:
--------------------------------------------
Yes, let's do that here as well.
Probably this should wait until LUCENE-2355 is done -- that's a big refactoring that Earwin is working on -- Earwin how is that going?
> Composite readers (Multi/DirIndexReader) should not subclass IndexReader
> ------------------------------------------------------------------------
>
> Key: LUCENE-2439
> URL: https://issues.apache.org/jira/browse/LUCENE-2439
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Fix For: 4.0.0
>
>
> I'd like to change Multi/DirIndexReader so that they no longer implement the low level methods of IndexReader, and instead act more like an ordered collection of sub readers. I think to do this we'd need a new interface, common to atomic readers (SegmentReader) and the composite readers, which IndexSearcher would accept.
> We should also require that the core Query scorers always receive an atomic reader.
> We've taken strong initial steps here with flex, by forcing users to use separate MultiFields static methods to obtain Fields/Terms/etc. from a composite reader. This issue is to finish this cutover.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2439) Composite readers
(Multi/DirIndexReader) should not subclass IndexReader
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863667#action_12863667 ]
Shai Erera commented on LUCENE-2439:
------------------------------------
On this thread http://www.mail-archive.com/java-dev@lucene.apache.org/msg37497.html I've also proposed to make isDeleted final, which was somehow related to making this change. So if you're at it already, do you think this can be done here as well?
> Composite readers (Multi/DirIndexReader) should not subclass IndexReader
> ------------------------------------------------------------------------
>
> Key: LUCENE-2439
> URL: https://issues.apache.org/jira/browse/LUCENE-2439
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Fix For: 4.0.0
>
>
> I'd like to change Multi/DirIndexReader so that they no longer implement the low level methods of IndexReader, and instead act more like an ordered collection of sub readers. I think to do this we'd need a new interface, common to atomic readers (SegmentReader) and the composite readers, which IndexSearcher would accept.
> We should also require that the core Query scorers always receive an atomic reader.
> We've taken strong initial steps here with flex, by forcing users to use separate MultiFields static methods to obtain Fields/Terms/etc. from a composite reader. This issue is to finish this cutover.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org