You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Eli Reisman (JIRA)" <ji...@apache.org> on 2012/08/30 01:15:07 UTC
[jira] [Commented] (GIRAPH-316) Add test-patch.sh for precommit
test using Jenkins
[ https://issues.apache.org/jira/browse/GIRAPH-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444520#comment-13444520 ]
Eli Reisman commented on GIRAPH-316:
------------------------------------
So after this is committed you will fix the jira path? I have not used Jenkins too much and am not sure if I should attempt to test this for real somehow or just commit and let you work with it? Its a great idea!
> Add test-patch.sh for precommit test using Jenkins
> --------------------------------------------------
>
> Key: GIRAPH-316
> URL: https://issues.apache.org/jira/browse/GIRAPH-316
> Project: Giraph
> Issue Type: Sub-task
> Components: test
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Attachments: GIRAPH-316_2.patch, GIRAPH-316.patch
>
>
> For automatic pre-commit tests by jenkins, we need a script for downloading the recent patch, compiling the patched source, and checking warnings. This patch includes the script. I borrowed test-patch.sh from Hadoop, and I modified the following things:
> * Hadoop's test-patch does not allow any javadoc warnings, but this patch allows them and does not allow the increase of javadoc warnings. This is because the current implementation of Giraph already has 47 javadoc warnings.
> * Add the checkstyle check which is not implemented in Hadoop's one.
> * Add an options to take jira user as an argument.
> * Add some codes related to the project directory structure and some messages.
> * Changed some codes to reflect the target directory hierarchy caused by munged.
> You can check the integrated test from https://builds.apache.org/job/PreCommit-GIRAPH-Build/. To execute the test, please click 'Build now' and type the number of Giraph jira issue. Now, I gave the wrong path of the jira cli to jenkins because I don't want to disturb the jira. So, you see "no such file/directory" error in "Adding comment to jira" section)
> After this patch is committed, I'll ask the automatic jenkins hook to builds@a.o as described in http://wiki.apache.org/general/PreCommitBuilds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira