You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/16 04:15:39 UTC
[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #4648: replace the arithmetic op for decimal array op decimal array using arrow kernel
liukun4515 commented on code in PR #4648:
URL: https://github.com/apache/arrow-datafusion/pull/4648#discussion_r1050356483
##########
datafusion/physical-expr/src/expressions/binary/kernels_arrow.rs:
##########
@@ -503,9 +444,6 @@ mod tests {
let left_decimal_array = create_decimal_array(&[Some(101)], 10, 1);
let right_decimal_array = create_decimal_array(&[Some(0)], 1, 1);
- let err =
Review Comment:
No,
The behavior of divide for decimal array with decimal array was changed.
In the previous implementation, we will check the 0 for dividend, but in the kernel `divide_opt` of arrow-rs, the result will be None if the right is zero
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org