You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/12/17 22:02:36 UTC
[GitHub] [beam] ahmedabu98 opened a new pull request, #24700: [BigQueryIO] Don't update schema of destination table when CREATE_IF_NEEDED is used with no schema provided
ahmedabu98 opened a new pull request, #24700:
URL: https://github.com/apache/beam/pull/24700
Follow up for #24471
Users are facing a problem when writing to BigQuery with `CREATE_IF_NEEDED` disposition and without providing a schema. After #24471, the destination schema is used to create temp tables when the user-provided schema is null.
This PR fixes something that #24471 missed, which is to skip the schema update step when user-provided schema is null. Also adds tests to verify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24700: [BigQueryIO] Don't update schema of destination table when CREATE_IF_NEEDED is used with no schema provided
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24700:
URL: https://github.com/apache/beam/pull/24700#issuecomment-1357557964
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kileys for label java.
R: @chamikaramj for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #24700: [BigQueryIO] Don't update schema of destination table when no schema is provided
Posted by GitBox <gi...@apache.org>.
Abacn merged PR #24700:
URL: https://github.com/apache/beam/pull/24700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #24700: [BigQueryIO] Don't update schema of destination table when CREATE_IF_NEEDED is used with no schema provided
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #24700:
URL: https://github.com/apache/beam/pull/24700#issuecomment-1356481561
Waiting for #24699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #24700: [BigQueryIO] Don't update schema of destination table when no schema is provided
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #24700:
URL: https://github.com/apache/beam/pull/24700#issuecomment-1364937022
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #24700: [BigQueryIO] Don't update schema of destination table when no schema is provided
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #24700:
URL: https://github.com/apache/beam/pull/24700#issuecomment-1365278188
@Abacn
Without this PR, this wouldn't work with large writes (ie. writing without specifying a schema):
```
BigQueryIO
.writeTableRows()
.to(OutputTable)
.withCreateDisposition(CreateDisposition.CREATE_NEVER))
```
As it is now, the write would get stuck in `UpdateSchemaDestination` trying to update final destination table schema with a null schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #24700: [BigQueryIO] Don't update schema of destination table when no schema is provided
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #24700:
URL: https://github.com/apache/beam/pull/24700#issuecomment-1365278224
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org