You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2017/03/03 02:48:18 UTC
[GitHub] cordova-lib pull request #524: CB-12528 use fs instead of our own existsSync
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-lib/pull/524
CB-12528 use fs instead of our own existsSync
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Lib
### What does this PR do?
Removes unneeded API
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-lib CB-12528
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/524.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #524
----
commit 62d491f3ff107ab03957ded15603667bf68e692f
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2017-03-03T02:08:52Z
use fs instead of our own existsSync
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #524: CB-12528 use fs instead of our own existsSync
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/524
It was deprecated for a time but then got undeprecated. Great find! https://github.com/nodejs/node/issues/1592
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #524: CB-12528 use fs instead of our own existsSync
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/524
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=h1) Report
> Merging [#524](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/b0402b9e51bf2d97488fedd39d13348b29f81c3c?src=pr&el=desc) will **decrease** coverage by `-0.02%`.
> The diff coverage is `100%`.
```diff
@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 81.9% 81.88% -0.02%
==========================================
Files 68 68
Lines 5504 5498 -6
Branches 1090 1090
==========================================
- Hits 4508 4502 -6
Misses 996 996
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=tree) | Coverage \u0394 | |
|---|---|---|
| [cordova-lib/src/util/npm-helper.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...62d491f3ff107ab03957ded15603667bf68e692f?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3V0aWwvbnBtLWhlbHBlci5qcw==) | `95.65% <100%> (�)` | :white_check_mark: |
| [cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...62d491f3ff107ab03957ded15603667bf68e692f?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==) | `97.2% <100%> (-0.08%)` | :x: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=footer). Last update [b0402b9...62d491f](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...62d491f3ff107ab03957ded15603667bf68e692f?src=pr&el=footer&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #524: CB-12528 use fs instead of our own existsSync
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/524
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org