You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ashishvijaywargiya (via GitHub)" <gi...@apache.org> on 2026/08/16 09:03:46 UTC
[PR] Fix timing-dependent race in QuoteTests.testCreateQuoteWorkEffortFail [ofbiz-framework]
ashishvijaywargiya opened a new pull request, #1659:
URL: https://github.com/apache/ofbiz-framework/pull/1659
The test verified nothing changed by checking for a QuoteWorkEffort row with lastUpdatedStamp >= a timestamp captured at test start. Since the prior test creates a row with the same quoteId/workEffortId just before this one runs, the two timestamps can land in the same millisecond, making the check match the earlier test's row and fail the assertion even though nothing was actually changed.
Compare the row before and after the service call instead, which does not depend on timestamp precision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix timing-dependent race in QuoteTests.testCreateQuoteWorkEffortFail [ofbiz-framework]
Posted by "ashishvijaywargiya (via GitHub)" <gi...@apache.org>.
ashishvijaywargiya closed pull request #1659: Fix timing-dependent race in QuoteTests.testCreateQuoteWorkEffortFail
URL: https://github.com/apache/ofbiz-framework/pull/1659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix timing-dependent race in QuoteTests.testCreateQuoteWorkEffortFail [ofbiz-framework]
Posted by "ashishvijaywargiya (via GitHub)" <gi...@apache.org>.
ashishvijaywargiya merged PR #1659:
URL: https://github.com/apache/ofbiz-framework/pull/1659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org